Allow more complex InlineArray initializations to end up in a statically initialized global #81649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l initializer functions. Inlining constructors into global initializers increase the changes that the global can be initialized statically.
It is like `zeroInitializer`, but does not actually initialize the memory. It only indicates to mandatory passes that the memory is going to be initialized.
…er` when generating SIL for `Builtin.emplace` `zeroInitializer` is blocking optimizations, but it is not needed because the closure of `Builtin.emplace` will initialize the memory anyway. We only need to tell mandatory passes that this memory should be treated as initialized.
…interToAddress.swift to OptUtils.swift
…rays Instead of looking for a single store to the global in a global-init function, build a GlobalInitValue tree. This is a data structure representing the init value of the global. It can handle complex InlineArray initializations, like `init(repeating:)`. rdar://150859232
…wift to SimplifyLoad.swift Because it's not used anywhere else anymore
eeckstein
requested review from
jckarter,
kavon,
rjmccall,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
eeckstein
requested review from
kubamracek,
atrick,
meg-gupta and
nate-chandler
and removed request for
xedin,
slavapestov,
kavon,
rjmccall and
hborla
|
@swift-ci apple silicon benchmark |
hamishknight
added a commit
to hamishknight/swift
that referenced
this pull request
May 22, 2025
…nearray-initialization" This reverts commit 0ceb517.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main part of this PR is to rewrite the InitializeStaticGlobals pass. Instead of looking for a single store to the global in a global-init function, it builds a
GlobalInitValuetree. This is a data structure representing the init value of the global. It can handle complex InlineArray initializations, likeinit(repeating:).Some other changes were necessary to make this work:
prepareInitializationinstead ofzeroInitializerwhen generating SIL forBuiltin.emplacerdar://150859232