Skip to content

[6.2] Sema: Fix an issue with NonisolatedNonsendingByDefault migration fo… #81655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AnthonyLatsis
Copy link
Collaborator

…r closures

  • Explanation: See the inline comments for details on the specific cases. Adding @concurrent to a closure’s type signature will sometimes break code due to parsing and type-checking behaviors. Fix this by also adding inferred effects to the signature in these cases.
  • Scope: NonisolatedNonsendingByDefault migration diagnostics QoI.
  • Issues: —
  • Original PRs: Sema: Fix an issue with NonisolatedNonsendingByDefault migration fo… #81633
  • Risk: Very low.
  • Testing: Added regression tests.
  • Reviewers: @xedin

…r closures

See the inline comments for more details. Depending on the closure's
type signature, sometimes adding the attribute will break code. Fix this
by also adding inferred effects to the signature in these cases.

(cherry picked from commit 2d7e040)
@AnthonyLatsis AnthonyLatsis requested a review from a team as a code owner May 20, 2025 23:26
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test

@AnthonyLatsis AnthonyLatsis enabled auto-merge May 21, 2025 11:09
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test

@AnthonyLatsis AnthonyLatsis merged commit c1ad869 into swiftlang:release/6.2 May 21, 2025
5 checks passed
@AnthonyLatsis AnthonyLatsis deleted the acer-campestri-2-6.2 branch May 21, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants