[Strict memory safety] Lift "unsafe" in pattern match expressions #81675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an "unsafe" expression is used as the case expression, lift it up so it also covers the synthesized matching expression (`=~`). This eliminates some unsuppressible strict memory safety warnings. Fixes rdar://151731850.
Use the argument type rather than the (potentially generic) parameter type.
|
@swift-ci please smoke test |
AnthonyLatsis
approved these changes
May 21, 2025
Comment on lines
+771
to
+778
| auto subExpr = EP->getSubExpr(); | ||
|
|
||
| // Pull off the outer "unsafe" expression. | ||
| UnsafeExpr *unsafeExpr = dyn_cast<UnsafeExpr>(subExpr); | ||
| if (unsafeExpr) { | ||
| subExpr = unsafeExpr->getSubExpr(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can UnsafeExpr be wrapped in an IdentityExpr?
There was a problem hiding this comment.
Hmmm. It's possible that we could have a try unsafe or similar here.
There was a problem hiding this comment.
So, that is broken, but I'm going to file a follow-up bug for myself because the try unsafe case is annoyingly hard to fix without breaking internal invariants.
hamishknight
added a commit
to hamishknight/swift
that referenced
this pull request
May 22, 2025
…tern-match" This reverts commit 689491c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an "unsafe" expression is used as the case expression, lift it up so it also covers the synthesized matching expression (
=~). This eliminates some unsuppressible strict memory safety warnings.While here, clean up the error messages for call arguments a bit so we show the proper types.
Fixes rdar://151731850.