Skip to content

[6.2][Concurrent] Restore old symbol for obsoleted Task.startSynchronously #81820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented May 28, 2025

Description: #80821 added @isolated(any) which is an ABI breaking change but since we are not planning to keep this API around, let's use @_silgen_name to bring the old name back for now.

Scope/Impact: ABI of method which will be removed eventually. Impacts only projects which adopted the previous API.
Risk: Low, this only fixes symbol names
Testing: Verified right symbols manually
Reviewed by: @ktoso (PR by @xedin)

Original PR: #81817
Radar: rdar://152178221

swiftlang#80821 added `@isolated(any)`
which is an ABI breaking change but since we are not planning to keep
this API around, let's use `@_silgen_name` to bring the old name back
for now.

Resolves: rdar://152178221
@ktoso ktoso requested a review from a team as a code owner May 28, 2025 22:34
@ktoso
Copy link
Contributor Author

ktoso commented May 28, 2025

@swift-ci please test

@ktoso ktoso changed the title [Concurrent] Restored old symbol for obsoleted Task.startSynchronously [6.2][Concurrent] Restored old symbol for obsoleted Task.startSynchronously May 28, 2025
@ktoso ktoso enabled auto-merge May 28, 2025 22:53
@ktoso ktoso added concurrency Feature: umbrella label for concurrency language features 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels May 28, 2025
@xedin xedin changed the title [6.2][Concurrent] Restored old symbol for obsoleted Task.startSynchronously [6.2][Concurrent] Restore old symbol for obsoleted Task.startSynchronously May 29, 2025
@ktoso ktoso merged commit 5baa624 into swiftlang:release/6.2 May 29, 2025
5 checks passed
@ktoso ktoso deleted the pick-abi-fix-startSynchronously branch May 29, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Feature: umbrella label for concurrency language features 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants