[GSB] Diagnose redundant same-type constraints. #8263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstraints. It's better to compute this information once while we're sorting through all of the same-type constraints, so we can use it later when performing queries (e.g., enumerating requirements).
Diagnose redundant same-type constraints using most of the same machinery for diagnosing other redundant constraints. However, same-type constraints are particularly interesting because redundancies can be spelled in a number of different ways. Address this using the connected components of the subgraph involving only derived requirements (which is already used for the minimized generic signature). Then, separate all of the non-derived requirements into the intracomponent requirements and intercomponent requirements: * All of the intracomponent requirements are redundant by definition, because the components are defined by derived constraints. * For the intercomponent requirements, form a spanning tree among the various components and diagnose as redundant any edges that do not extend the spanning tree.
|
@swift-ci please smoke test and merge |
slavapestov
reviewed
Mar 22, 2017
| @@ -1,4 +1,4 @@ | |||
| // RUN: %target-typecheck-verify-swift | |||
| // RUN: %target-typecheck-verify-swift -swift-version 4 | |||
There was a problem hiding this comment.
What changed between 3 and 4 here?
There was a problem hiding this comment.
I'm using a "where" clause on a protocol in one of the later tests.
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnose redundant same-type constraints using most of the same
machinery for diagnosing other redundant constraints. However,
same-type constraints are particularly interesting because
redundancies can be spelled in a number of different ways. Address
this using the connected components of the subgraph involving only
derived requirements (which is already used for the minimized generic
signature). Then, separate all of the non-derived requirements into
the intracomponent requirements and intercomponent requirements:
All of the intracomponent requirements are redundant by definition,
because the components are defined by derived constraints.
For the intercomponent requirements, form a spanning tree among the
various components and diagnose as redundant any edges that do not
extend the spanning tree.