Skip to content

Quickhelp xml swift 4.0 branch #8894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2017
Merged

Quickhelp xml swift 4.0 branch #8894

merged 2 commits into from
Apr 21, 2017

Conversation

mxswd
Copy link
Contributor

@mxswd mxswd commented Apr 20, 2017

Cherry pick.

@mxswd mxswd requested a review from bitjammer April 20, 2017 21:22
bitjammer
bitjammer approved these changes Apr 20, 2017
View reviewed changes
Copy link
Contributor

@bitjammer bitjammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests are fine, again, LGTM.

@mxswd
Copy link
Contributor Author

mxswd commented Apr 20, 2017

@swift-ci please smoke test and merge

@jrose-apple
Copy link
Contributor

Release branches need a full test before you can merge.

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - a04fee7
Test requested by - @jrose-apple

@jrose-apple
Copy link
Contributor

Unrelated Linux failure.

@swift-ci Please test Linux

@bitjammer bitjammer merged commit 5275905 into swiftlang:swift-4.0-branch Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitjammer bitjammer bitjammer approved these changes

@anuragranjan629 anuragranjan629 anuragranjan629 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mxswd @jrose-apple @swift-ci @bitjammer @anuragranjan629