[Parse] Don't tell CodeCompletion nonsense about protocol/AT where clauses. #9419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge. |
|
@huonw the failing test is a crasher test case I added for this exact bug. If you want, you can resolve it and remove your newly-added test (or remove mine, or keep both). |
|
@swift-ci Please smoke test OSX. |
|
@swift-ci Please smoke test |
huonw
force-pushed
the
where-completion-crash
branch
from
81a9d9f to
6c274df
Compare
|
@swift-ci Please smoke test and merge. |
|
@swift-ci Please smoke test |
…auses. This doesn't give particularly useful information yet (i.e. Self isn't listed, see rdar://problem/31981641 ), but it does stop the completion code from just directly crashing. Fixes rdar://problem/31981486.
huonw
force-pushed
the
where-completion-crash
branch
from
6c274df to
8c8f35e
Compare
|
@swift-ci Please smoke test and merge. |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't give particularly useful information yet (i.e. Self isn't
listed, see rdar://problem/31981641 ), but it does stop the completion
code from just directly crashing.
Fixes rdar://problem/31981486.
(Isn't it great when your own fixme's come back to bite you.)