Runtime: Add newline to implicit ObjC entrypoint log message. #9747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See if this clears up buffering issues in CI. rdar://problem/32272992
|
@swift-ci please test |
|
I'll review as this is Joe's change. LGTM. Github UI likes to have a reviewer who isn't the PR opener, so putting it at Joe |
|
Build failed |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See if this clears up buffering issues in CI. rdar://problem/32272992
Cherry-picked from @jckarter #9734
CCC
Explanation: Inconsistent testing arose due to buffering of expected output not newline terminated
Scope: Limited to tests
Radar (and possibly SR Issue): rdar://problem/32272992
Risk: Low, limited only to tests
Testing: CI testing