Add missing ? in “did you mean …” diagnostics

Author: ftchirou

include/swift/AST/DiagnosticsSema.def

@@ -107,7 +107,7 @@ ERROR(could_not_find_subscript_member_did_you_mean,none,
       (Type))
 
 ERROR(could_not_find_enum_case,none,
-      "enum type %0 has no case %1; did you mean %2",
+      "enum type %0 has no case %1; did you mean %2?",
       (Type, DeclNameRef, DeclName))
 
 NOTE(did_you_mean_raw_type,none,
@@ -951,7 +951,7 @@ NOTE(in_cast_expr_types,none,
       (Type, Type))
 
 ERROR(types_not_convertible_use_bool_value,none,
-      "%0 is not convertible to %1; did you mean %0.boolValue", (Type, Type))
+      "%0 is not convertible to %1; did you mean %0.boolValue?", (Type, Type))
 
 ERROR(tuple_types_not_convertible_nelts,none,
       "%0 is not convertible to %1, "

test/Constraints/diagnostics.swift

@@ -529,8 +529,8 @@ let _: Color = .frob(1, b: i)  // expected-error {{passing value of type 'Int' t
 let _: Color = .frob(1, &d) // expected-error {{missing argument label 'b:' in call}}
 // expected-error@-1 {{cannot convert value of type 'Double' to expected argument type 'Int'}}
 let _: Color = .frob(1, b: &d) // expected-error {{cannot convert value of type 'Double' to expected argument type 'Int'}}
-var someColor : Color = .red // expected-error {{enum type 'Color' has no case 'red'; did you mean 'Red'}}
-someColor = .red  // expected-error {{enum type 'Color' has no case 'red'; did you mean 'Red'}}
+var someColor : Color = .red // expected-error {{enum type 'Color' has no case 'red'; did you mean 'Red'?}}
+someColor = .red  // expected-error {{enum type 'Color' has no case 'red'; did you mean 'Red'?}}
 someColor = .svar() // expected-error {{cannot call value of non-function type 'Color'}}
 someColor = .svar(1) // expected-error {{cannot call value of non-function type 'Color'}}
 

test/Constraints/enum_cases.swift

@@ -121,7 +121,7 @@ func rdar34583132() {
 
   func bar(_ s: S) {
     guard s.foo(1 + 2) == .timeout else {
-    // expected-error@-1 {{enum type 'E' has no case 'timeout'; did you mean 'timeOut'}}
+    // expected-error@-1 {{enum type 'E' has no case 'timeout'; did you mean 'timeOut'?}}
       fatalError()
     }
   }

test/Constraints/keyword_arguments.swift

@@ -349,14 +349,14 @@ func trailingClosure6<T>(value: Int, expression: () -> T?) { }
 trailingClosure5(file: "hello", line: 17) { // expected-error{{extraneous argument label 'file:' in call}}{{18-24=}}
 // expected-error@-1 {{generic parameter 'T' could not be inferred}}
   return Optional.Some(5)
-  // expected-error@-1 {{enum type 'Optional<Wrapped>' has no case 'Some'; did you mean 'some'}} {{19-23=some}}
+  // expected-error@-1 {{enum type 'Optional<Wrapped>' has no case 'Some'; did you mean 'some'?}} {{19-23=some}}
   // expected-error@-2 {{generic parameter 'Wrapped' could not be inferred}}
   // expected-note@-3 {{explicitly specify the generic arguments to fix this issue}}
 }
 trailingClosure6(5) { // expected-error{{missing argument label 'value:' in call}}{{18-18=value: }}
 // expected-error@-1 {{generic parameter 'T' could not be inferred}}
   return Optional.Some(5)
-  // expected-error@-1 {{enum type 'Optional<Wrapped>' has no case 'Some'; did you mean 'some'}} {{19-23=some}}
+  // expected-error@-1 {{enum type 'Optional<Wrapped>' has no case 'Some'; did you mean 'some'?}} {{19-23=some}}
   // expected-error@-2 {{generic parameter 'Wrapped' could not be inferred}}
   // expected-note@-3 {{explicitly specify the generic arguments to fix this issue}}
 }

test/NameBinding/name_lookup.swift

@@ -553,9 +553,9 @@ default:
 }
 
 func foo() {
-  _ = MyEnum.One // expected-error {{enum type 'MyEnum' has no case 'One'; did you mean 'one'}}{{14-17=one}}
-  _ = MyEnum.Two // expected-error {{enum type 'MyEnum' has no case 'Two'; did you mean 'two'}}{{14-17=two}}
-  _ = MyEnum.OneTwoThree // expected-error {{enum type 'MyEnum' has no case 'OneTwoThree'; did you mean 'oneTwoThree'}}{{14-25=oneTwoThree}}
+  _ = MyEnum.One // expected-error {{enum type 'MyEnum' has no case 'One'; did you mean 'one'?}}{{14-17=one}}
+  _ = MyEnum.Two // expected-error {{enum type 'MyEnum' has no case 'Two'; did you mean 'two'?}}{{14-17=two}}
+  _ = MyEnum.OneTwoThree // expected-error {{enum type 'MyEnum' has no case 'OneTwoThree'; did you mean 'oneTwoThree'?}}{{14-25=oneTwoThree}}
 }
 
 enum MyGenericEnum<T> {
@@ -564,8 +564,8 @@ enum MyGenericEnum<T> {
 }
 
 func foo1() {
-  _ = MyGenericEnum<Int>.One // expected-error {{enum type 'MyGenericEnum<Int>' has no case 'One'; did you mean 'one'}}{{26-29=one}}
-  _ = MyGenericEnum<Int>.OneTwo // expected-error {{enum type 'MyGenericEnum<Int>' has no case 'OneTwo'; did you mean 'oneTwo'}}{{26-32=oneTwo}}
+  _ = MyGenericEnum<Int>.One // expected-error {{enum type 'MyGenericEnum<Int>' has no case 'One'; did you mean 'one'?}}{{26-29=one}}
+  _ = MyGenericEnum<Int>.OneTwo // expected-error {{enum type 'MyGenericEnum<Int>' has no case 'OneTwo'; did you mean 'oneTwo'?}}{{26-32=oneTwo}}
 }
 
 // SR-4082