Don't use SILBoxType::getBoxedType() in isUnspecializedGeneric.

jckarter · jckarter · commit 68b2cb7c687a · 2016-12-02T15:19:43.000-08:00
NFC, since it's unlikely anyone would ask this of a SIL-only type to begin with.
diff --git a/lib/AST/Type.cpp b/lib/AST/Type.cpp
@@ -375,8 +375,11 @@ bool TypeBase::isUnspecializedGeneric() {
     return cast<SILBlockStorageType>(this)->getCaptureType()
         ->isUnspecializedGeneric();
   case TypeKind::SILBox:
-    return cast<SILBoxType>(this)->getBoxedType()
-        ->isUnspecializedGeneric();
+    for (auto &arg : cast<SILBoxType>(this)->getGenericArgs()) {
+      if (arg.getReplacement()->isUnspecializedGeneric())
+        return true;
+    }
+    return false;
   }
   llvm_unreachable("bad TypeKind");
 }

Original file line number	Diff line number	Diff line change
`@@ -375,8 +375,11 @@ bool TypeBase::isUnspecializedGeneric() {`
`375`	`375`	`return cast<SILBlockStorageType>(this)->getCaptureType()`
`376`	`376`	`->isUnspecializedGeneric();`
`377`	`377`	`case TypeKind::SILBox:`
`378`		`- return cast<SILBoxType>(this)->getBoxedType()`
`379`		`- ->isUnspecializedGeneric();`
	`378`	`+ for (auto &arg : cast<SILBoxType>(this)->getGenericArgs()) {`
	`379`	`+ if (arg.getReplacement()->isUnspecializedGeneric())`
	`380`	`+ return true;`
	`381`	`+ }`
	`382`	`+ return false;`
`380`	`383`	`}`
`381`	`384`	`llvm_unreachable("bad TypeKind");`
`382`	`385`	`}`