Skip to content

Commit 89c59fa

Browse files
JaZoJaZo
committed
Use createMock instead of getMockBuilder
1 parent c9e6813 commit 89c59fa

File tree

3 files changed

+20
-21
lines changed

3 files changed

+20
-21
lines changed

‎tests/DocumentClientTest.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class DocumentClientTest extends AbstractTest
1818
public function the_base_url_can_be_changed_after_instantiation()
1919
{
2020
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\ClientInterface $client */
21-
$client = $this->getMockBuilder(ClientInterface::class)->getMock();
21+
$client = $this->createMock(ClientInterface::class);
2222

2323
$client->expects($this->once())
2424
->method('getBaseUri')
@@ -29,7 +29,7 @@ public function the_base_url_can_be_changed_after_instantiation()
2929
->with('http://www.test-changed.com');
3030

3131
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\ResponseParserInterface $parser */
32-
$parser = $this->getMockBuilder(ResponseParserInterface::class)->getMock();
32+
$parser = $this->createMock(ResponseParserInterface::class);
3333

3434
$documentClient = new DocumentClient($client, $parser);
3535

@@ -46,15 +46,15 @@ public function it_builds_a_get_request()
4646
$document = new Document();
4747

4848
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\ClientInterface $client */
49-
$client = $this->getMockBuilder(ClientInterface::class)->getMock();
49+
$client = $this->createMock(ClientInterface::class);
5050

5151
$client->expects($this->once())
5252
->method('get')
5353
->with('/test/1', ['X-Foo' => 'bar'])
5454
->willReturn($response);
5555

5656
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\ResponseParserInterface $parser */
57-
$parser = $this->getMockBuilder(ResponseParserInterface::class)->getMock();
57+
$parser = $this->createMock(ResponseParserInterface::class);
5858

5959
$parser->expects($this->once())
6060
->method('parse')
@@ -77,15 +77,15 @@ public function it_builds_a_delete_request()
7777
$document = new Document();
7878

7979
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\ClientInterface $client */
80-
$client = $this->getMockBuilder(ClientInterface::class)->getMock();
80+
$client = $this->createMock(ClientInterface::class);
8181

8282
$client->expects($this->once())
8383
->method('delete')
8484
->with('/test/1', ['X-Foo' => 'bar'])
8585
->willReturn($response);
8686

8787
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\ResponseParserInterface $parser */
88-
$parser = $this->getMockBuilder(ResponseParserInterface::class)->getMock();
88+
$parser = $this->createMock(ResponseParserInterface::class);
8989

9090
$parser->expects($this->once())
9191
->method('parse')
@@ -110,15 +110,15 @@ public function it_builds_a_patch_request()
110110
$itemDocument->setData((new Item())->setType('test')->setId('1'));
111111

112112
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\ClientInterface $client */
113-
$client = $this->getMockBuilder(ClientInterface::class)->getMock();
113+
$client = $this->createMock(ClientInterface::class);
114114

115115
$client->expects($this->once())
116116
->method('patch')
117117
->with('/test/1', '{"data":{"type":"test","id":"1"}}', ['X-Foo' => 'bar'])
118118
->willReturn($response);
119119

120120
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\ResponseParserInterface $parser */
121-
$parser = $this->getMockBuilder(ResponseParserInterface::class)->getMock();
121+
$parser = $this->createMock(ResponseParserInterface::class);
122122

123123
$parser->expects($this->once())
124124
->method('parse')
@@ -143,15 +143,15 @@ public function it_builds_a_post_request()
143143
$itemDocument->setData((new Item())->setType('test'));
144144

145145
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\ClientInterface $client */
146-
$client = $this->getMockBuilder(ClientInterface::class)->getMock();
146+
$client = $this->createMock(ClientInterface::class);
147147

148148
$client->expects($this->once())
149149
->method('post')
150150
->with('/test/1', '{"data":{"type":"test"}}', ['X-Foo' => 'bar'])
151151
->willReturn($response);
152152

153153
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\ResponseParserInterface $parser */
154-
$parser = $this->getMockBuilder(ResponseParserInterface::class)->getMock();
154+
$parser = $this->createMock(ResponseParserInterface::class);
155155

156156
$parser->expects($this->once())
157157
->method('parse')

‎tests/Relations/AbstractManyRelationTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,8 @@ public function it_can_sort_the_included()
7777
/** @var \PHPUnit\Framework\MockObject\MockObject&\Swis\JsonApi\Client\Relations\AbstractManyRelation $mock */
7878
$mock = $this->getMockForAbstractClass(AbstractManyRelation::class);
7979
/** @var \PHPUnit\Framework\MockObject\MockObject&\Swis\JsonApi\Client\Collection $collectionMock */
80-
$collectionMock = $this->getMockBuilder(Collection::class)
81-
->onlyMethods(['sortBy'])
82-
->getMock();
80+
$collectionMock = $this->createMock(Collection::class);
81+
8382
$collectionMock->expects($this->once())
8483
->method('sortBy')
8584
->with('foo', SORT_NATURAL, true);

‎tests/RepositoryTest.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class RepositoryTest extends TestCase
1818
public function it_can_get_the_client()
1919
{
2020
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\DocumentClientInterface $client */
21-
$client = $this->getMockBuilder(DocumentClientInterface::class)->getMock();
21+
$client = $this->createMock(DocumentClientInterface::class);
2222
$repository = new MockRepository($client, new DocumentFactory());
2323

2424
$this->assertSame($client, $repository->getClient());
@@ -30,7 +30,7 @@ public function it_can_get_the_client()
3030
public function it_can_get_the_endpoint()
3131
{
3232
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\DocumentClientInterface $client */
33-
$client = $this->getMockBuilder(DocumentClientInterface::class)->getMock();
33+
$client = $this->createMock(DocumentClientInterface::class);
3434
$repository = new MockRepository($client, new DocumentFactory());
3535

3636
$this->assertSame('mocks', $repository->getEndpoint());
@@ -44,7 +44,7 @@ public function it_can_get_all()
4444
$document = new Document();
4545

4646
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\DocumentClientInterface $client */
47-
$client = $this->getMockBuilder(DocumentClientInterface::class)->getMock();
47+
$client = $this->createMock(DocumentClientInterface::class);
4848

4949
$client->expects($this->once())
5050
->method('get')
@@ -64,7 +64,7 @@ public function it_can_take_one()
6464
$document = new Document();
6565

6666
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\DocumentClientInterface $client */
67-
$client = $this->getMockBuilder(DocumentClientInterface::class)->getMock();
67+
$client = $this->createMock(DocumentClientInterface::class);
6868

6969
$client->expects($this->once())
7070
->method('get')
@@ -84,7 +84,7 @@ public function it_can_find_one()
8484
$document = new Document();
8585

8686
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\DocumentClientInterface $client */
87-
$client = $this->getMockBuilder(DocumentClientInterface::class)->getMock();
87+
$client = $this->createMock(DocumentClientInterface::class);
8888

8989
$client->expects($this->once())
9090
->method('get')
@@ -105,7 +105,7 @@ public function it_can_save_new()
105105
$document->setData(new Item());
106106

107107
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\DocumentClientInterface $client */
108-
$client = $this->getMockBuilder(DocumentClientInterface::class)->getMock();
108+
$client = $this->createMock(DocumentClientInterface::class);
109109

110110
$client->expects($this->once())
111111
->method('post')
@@ -126,7 +126,7 @@ public function it_can_save_existing()
126126
$document->setData((new Item())->setId(1));
127127

128128
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\DocumentClientInterface $client */
129-
$client = $this->getMockBuilder(DocumentClientInterface::class)->getMock();
129+
$client = $this->createMock(DocumentClientInterface::class);
130130

131131
$client->expects($this->once())
132132
->method('patch')
@@ -146,7 +146,7 @@ public function it_can_delete()
146146
$document = new Document();
147147

148148
/** @var \PHPUnit\Framework\MockObject\MockObject|\Swis\JsonApi\Client\Interfaces\DocumentClientInterface $client */
149-
$client = $this->getMockBuilder(DocumentClientInterface::class)->getMock();
149+
$client = $this->createMock(DocumentClientInterface::class);
150150

151151
$client->expects($this->once())
152152
->method('delete')

0 commit comments

Comments
 (0)