Skip to content

Commit 9f694df

Browse files
killerwolfdbu
authored andcommitted
Fix symfony 2.8 build
1 parent 3c4b044 commit 9f694df

File tree

5 files changed

+10
-9
lines changed

5 files changed

+10
-9
lines changed

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ matrix:
2828
- php: 5.6
2929
env: SYMFONY_VERSION=3.0.*
3030
allow_failures:
31-
- env: SYMFONY_VERSION=2.8.*
3231
- env: SYMFONY_VERSION=3.0.*
3332
fast_finish: true
3433

Admin/RouteAdmin.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,9 @@ protected function configureFieldsForDefaults($dynamicDefaults)
150150
$textType = $isSf28 ? 'Symfony\Component\Form\Extension\Core\Type\TextType' : 'text';
151151

152152
$defaults = array(
153-
'_controller' => array('_controller', $textType, array('required' => false)),
154-
'_template' => array('_template', $textType, array('required' => false)),
155-
'type' => array('type', $isSf28 ? 'Symfony\Cmf\Bundle\RoutingBundle\Form\Type\RouteTypeType' : 'cmf_routing_route_type', array(
153+
'_controller' => array('_controller', Sf2CompatUtil::getFormTypeName('text'), array('required' => false)),
154+
'_template' => array('_template', Sf2CompatUtil::getFormTypeName('text'), array('required' => false)),
155+
'type' => array('type', Sf2CompatUtil::getFormTypeName('cmf_routing_route_type'), array(
156156
'empty_value' => '',
157157
'required' => false,
158158
)),

Controller/RedirectController.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
namespace Symfony\Cmf\Bundle\RoutingBundle\Controller;
1313

1414
use Symfony\Component\Routing\RouterInterface;
15+
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
1516
use Symfony\Component\HttpFoundation\RedirectResponse;
1617
use Symfony\Cmf\Component\Routing\RedirectRouteInterface;
1718

@@ -53,10 +54,10 @@ public function redirectAction(RedirectRouteInterface $contentDocument)
5354
if (empty($url)) {
5455
$routeTarget = $contentDocument->getRouteTarget();
5556
if ($routeTarget) {
56-
$url = $this->router->generate($routeTarget, $contentDocument->getParameters(), true);
57+
$url = $this->router->generate($routeTarget, $contentDocument->getParameters(), UrlGeneratorInterface::ABSOLUTE_URL);
5758
} else {
5859
$routeName = $contentDocument->getRouteName();
59-
$url = $this->router->generate($routeName, $contentDocument->getParameters(), true);
60+
$url = $this->router->generate($routeName, $contentDocument->getParameters(), UrlGeneratorInterface::ABSOLUTE_URL);
6061
}
6162
}
6263

Tests/Functional/Routing/DynamicRouterTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
use Symfony\Component\HttpFoundation\Request;
1616
use Symfony\Cmf\Component\Routing\ChainRouter;
1717
use Symfony\Cmf\Component\Routing\RouteObjectInterface;
18+
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
1819
use Symfony\Cmf\Bundle\RoutingBundle\Doctrine\Phpcr\Route;
1920
use Symfony\Cmf\Bundle\RoutingBundle\Doctrine\Phpcr\RedirectRoute;
2021
use Symfony\Cmf\Bundle\RoutingBundle\Routing\DynamicRouter;
@@ -347,7 +348,7 @@ public function testGenerate()
347348
public function testGenerateAbsolute()
348349
{
349350
$route = $this->getDm()->find(null, self::ROUTE_ROOT.'/testroute/child');
350-
$url = $this->router->generate($route, array('test' => 'value'), true);
351+
$url = $this->router->generate($route, array('test' => 'value'), UrlGeneratorInterface::ABSOLUTE_URL);
351352
$this->assertEquals('http://localhost/testroute/child?test=value', $url);
352353
}
353354

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
"symfony-cmf/testing": "~1.2,>=1.2.7",
2424
"doctrine/phpcr-odm": "~1.3",
2525
"matthiasnoback/symfony-dependency-injection-test": "~0.6",
26-
"matthiasnoback/symfony-config-test": "0.*",
26+
"matthiasnoback/symfony-config-test": "^1.3.1",
2727
"phpunit/php-code-coverage": "@stable",
28-
"sonata-project/doctrine-phpcr-admin-bundle": "~1.1",
28+
"sonata-project/doctrine-phpcr-admin-bundle": "^1.1",
2929
"symfony/monolog-bundle": "~2.3",
3030
"doctrine/orm": "~2.3",
3131
"doctrine/data-fixtures": "1.*,>=1.0.0-alpha3"

0 commit comments

Comments
 (0)