Skip to content

[WIP] added getters and setters for route flags #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2013
Merged

[WIP] added getters and setters for route flags #157

merged 1 commit into from
Aug 21, 2013

Conversation

lsmith77
Copy link
Member

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

lsmith77
lsmith77 reviewed Aug 21, 2013
View reviewed changes
Resources/translations/CmfRoutingBundle.de.xliff
@@ -98,6 +98,14 @@
<source>form.label_routes</source>
<target>Routen</target>
</trans-unit>
<trans-unit id=" form.label_add_format_pattern">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be translated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was done already on master

@lsmith77 lsmith77 mentioned this pull request Aug 21, 2013
Merged
lsmith77 added a commit that referenced this pull request Aug 21, 2013
@lsmith77
Merge pull request #157 from symfony-cmf/flag_getter_setter
d3cf54b 
[WIP] added getters and setters for route flags
@lsmith77 lsmith77 merged commit d3cf54b into master Aug 21, 2013
@lsmith77 lsmith77 deleted the flag_getter_setter branch August 21, 2013 18:46
@lsmith77 lsmith77 mentioned this pull request Aug 21, 2013
Closed
@wouterj
Copy link
Member

wouterj commented Aug 22, 2013

  1. you are missing values for ID in xliff
  2. please do not include non-translated text for other languages. The translation component will simple fallback to the english version

@lsmith77
Copy link
Member Author

fixed 2. but I dont understand 1.

@wouterj
Copy link
Member

wouterj commented Aug 23, 2013

yes, sorry 1 was my fault. But do you also see the space before each ID on github? I can't see them in my editor..

@lsmith77
Copy link
Member Author

yes i do. should be fixed in master by a later commit however

@dbu dbu mentioned this pull request Aug 24, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsmith77 @wouterj @cordoval