Skip to content

Symfony3 compatibility #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2016
Merged

Symfony3 compatibility #332

merged 1 commit into from
Feb 17, 2016

Conversation

hacfi
Copy link
Contributor

@hacfi hacfi commented Feb 17, 2016

  • allow Symfony ~3.0
  • bump Symfony dependency to ~2.7
  • specify correct Sonata dependencies
  • use parentDocument in Admin classes
  • update route_basepaths in tests
  • make StyleCI happy

See #331

…Sonata dependencies, use parentDocument in Admin classes, update route_basepaths in tests
@hacfi hacfi mentioned this pull request Feb 17, 2016
@@ -21,11 +21,9 @@ env:
matrix:
include:
- php: 5.6
env: DEPS=dev
env: DEPS=dev SYMFONY_VERSION=2.8.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I do one last try? :)

DEPS=dev SYMFONY_VERSION="3.0.x-dev as 2.8.x-dev"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or i just merge and we can do further PRs

dbu added a commit that referenced this pull request Feb 17, 2016
@dbu dbu merged commit 6b9ae4c into symfony-cmf:symfony3 Feb 17, 2016
@lsmith77 lsmith77 removed the wip/poc label Feb 17, 2016
@dbu
Copy link
Member

dbu commented Feb 17, 2016

thanks a lot @hacfi
i merged this so that we can do independent PRs to work on the build matrix and getting rid of deprecated / BC things.

@wouterj
Copy link
Member

wouterj commented Feb 17, 2016

We now have a symfony3 and symfony_3 branch, I think the one with the underscore has to be removed?

@dbu
Copy link
Member

dbu commented Feb 17, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants