Skip to content

Commit cb4f98c

Browse files
committed
Code review fixes
1 parent aa6c6d7 commit cb4f98c

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

Model/Page.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,9 @@ class Page extends Route implements
7575

7676
/**
7777
* Extra values an application can store along with a page
78+
* @var array
7879
*/
79-
protected $extras;
80+
protected $extras = array();
8081

8182
/**
8283
* Overwrite to be able to create route without pattern

Resources/config/doctrine-model/Page.phpcr.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
<field name="body" type="string" translated="true"/>
1717
<field name="createDate" type="date"/>
1818
<field name="publishable" type="boolean"/>
19-
<field name="publishStartDate" type="date"/>
20-
<field name="publishEndDate" type="date"/>
19+
<field name="publishStartDate" type="date" nullable="true"/>
20+
<field name="publishEndDate" type="date" nullable="true"/>
2121
<field name="addLocalePattern" type="boolean"/>
22-
<field name="extras" type="string" assoc=""/>
22+
<field name="extras" type="string" assoc="" nullable="true"/>
2323

2424
</mapped-superclass>
2525

Tests/WebTest/Admin/PageAdminTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public function testPageEdit()
2727
$crawler = $this->client->request('GET', '/admin/cmf/simplecms/page/test/page/homepage/edit');
2828
$res = $this->client->getResponse();
2929
$this->assertEquals(200, $res->getStatusCode());
30-
$this->assertCount(2, $crawler->filter('input[value="homepage"]'));
30+
$this->assertCount(2, $crawler->filter('input[value="Homepage"]'));
3131
}
3232

3333
public function testPageShow()

0 commit comments

Comments
 (0)