bug #149 [Stale] Check if issue is open before making a comment (Nyholm)

This PR was merged into the master branch.

Discussion
----------

[Stale] Check if issue is open before making a comment

Related to this: symfony/symfony#34002 (comment)

Commits
-------

5f1da28 [Stale] Check if issue is open before making a comment

Author: weaverryan

src/Service/TaskHandler/CloseStaleIssuesHandler.php

@@ -36,6 +36,12 @@ public function handle(Task $task): void
         if (null === $repository = $this->repositoryProvider->getRepository($task->getRepositoryFullName())) {
             return;
         }
+
+        $issue = $this->issueApi->show($repository, $task->getNumber());
+        if ('open' !== $issue['state']) {
+            return;
+        }
+
         $labels = $this->labelApi->getIssueLabels($task->getNumber(), $repository);
         if (in_array('Keep open', $labels)) {
             $this->labelApi->removeIssueLabel($task->getNumber(), 'Stalled', $repository);

src/Service/TaskHandler/InformAboutClosingStaleIssuesHandler.php

@@ -40,6 +40,12 @@ public function handle(Task $task): void
         if (null === $repository = $this->repositoryProvider->getRepository($task->getRepositoryFullName())) {
             return;
         }
+
+        $issue = $this->issueApi->show($repository, $task->getNumber());
+        if ('open' !== $issue['state']) {
+            return;
+        }
+
         $labels = $this->labelApi->getIssueLabels($task->getNumber(), $repository);
         if (in_array('Keep open', $labels)) {
             $this->labelApi->removeIssueLabel($task->getNumber(), 'Stalled', $repository);

tests/Service/TaskHandler/CloseStaleIssuesHandlerTest.php

@@ -24,8 +24,9 @@ public function testHandleKeepOpen()
 
         $issueApi = $this->getMockBuilder(NullIssueApi::class)
             ->disableOriginalConstructor()
-            ->setMethods(['close', 'lastCommentWasMadeByBot'])
+            ->setMethods(['close', 'lastCommentWasMadeByBot', 'show'])
             ->getMock();
+        $issueApi->expects($this->any())->method('show')->willReturn(['state' => 'open']);
         $issueApi->expects($this->any())->method('lastCommentWasMadeByBot')->willReturn(true);
         $issueApi->expects($this->never())->method('close');
 
@@ -45,8 +46,9 @@ public function testHandleComments()
 
         $issueApi = $this->getMockBuilder(NullIssueApi::class)
             ->disableOriginalConstructor()
-            ->setMethods(['close', 'lastCommentWasMadeByBot'])
+            ->setMethods(['close', 'lastCommentWasMadeByBot', 'show'])
             ->getMock();
+        $issueApi->expects($this->any())->method('show')->willReturn(['state' => 'open']);
         $issueApi->expects($this->any())->method('lastCommentWasMadeByBot')->willReturn(false);
         $issueApi->expects($this->never())->method('close');
 
@@ -66,8 +68,9 @@ public function testHandleStale()
 
         $issueApi = $this->getMockBuilder(NullIssueApi::class)
             ->disableOriginalConstructor()
-            ->setMethods(['close', 'lastCommentWasMadeByBot'])
+            ->setMethods(['close', 'lastCommentWasMadeByBot', 'show'])
             ->getMock();
+        $issueApi->expects($this->any())->method('show')->willReturn(['state' => 'open']);
         $issueApi->expects($this->any())->method('lastCommentWasMadeByBot')->willReturn(true);
         $issueApi->expects($this->once())->method('close');
 

tests/Service/TaskHandler/InformAboutClosingStaleIssuesHandlerTest.php

@@ -25,8 +25,9 @@ public function testHandleKeepOpen()
 
         $issueApi = $this->getMockBuilder(NullIssueApi::class)
             ->disableOriginalConstructor()
-            ->setMethods(['close', 'lastCommentWasMadeByBot'])
+            ->setMethods(['close', 'lastCommentWasMadeByBot', 'show'])
             ->getMock();
+        $issueApi->expects($this->any())->method('show')->willReturn(['state' => 'open']);
         $issueApi->expects($this->any())->method('lastCommentWasMadeByBot')->willReturn(true);
         $issueApi->expects($this->never())->method('close');
 
@@ -52,8 +53,9 @@ public function testHandleComments()
 
         $issueApi = $this->getMockBuilder(NullIssueApi::class)
             ->disableOriginalConstructor()
-            ->setMethods(['close', 'lastCommentWasMadeByBot'])
+            ->setMethods(['close', 'lastCommentWasMadeByBot', 'show'])
             ->getMock();
+        $issueApi->expects($this->any())->method('show')->willReturn(['state' => 'open']);
         $issueApi->expects($this->any())->method('lastCommentWasMadeByBot')->willReturn(false);
         $issueApi->expects($this->never())->method('close');
 
@@ -79,8 +81,9 @@ public function testHandleStale()
 
         $issueApi = $this->getMockBuilder(NullIssueApi::class)
             ->disableOriginalConstructor()
-            ->setMethods(['close', 'lastCommentWasMadeByBot'])
+            ->setMethods(['close', 'lastCommentWasMadeByBot', 'show'])
             ->getMock();
+        $issueApi->expects($this->any())->method('show')->willReturn(['state' => 'open']);
         $issueApi->expects($this->any())->method('lastCommentWasMadeByBot')->willReturn(true);
         $issueApi->expects($this->never())->method('close');