Skip to content

Commit d96a4a4

Browse files
committed
s
1 parent e59353c commit d96a4a4

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

src/Service/CodeNodeRunner.php

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,9 @@ private function getNodeContents(CodeNode $node, array $contents): string
107107
}
108108

109109
/**
110-
* Make sure PHP classes exists in the application directory
110+
* Make sure PHP classes exists in the application directory.
111+
*
112+
* @param list<string> $codeBlock
111113
*/
112114
private function verifyPhpClasses(CodeNode $node, IssueCollection $issues, array $codeBlock, string $applicationDirectory): void
113115
{
@@ -135,13 +137,13 @@ private function verifyPhpClasses(CodeNode $node, IssueCollection $issues, array
135137

136138
$explode = explode('\\', $class);
137139
if (
138-
$explode[0] === 'App' || $explode[0] === 'Acme'
139-
|| (count($explode) === 3 && $explode[0] === 'Symfony' && ($explode[1] === 'Component' || $explode[1] === 'Config'))
140+
'App' === $explode[0] || 'Acme' === $explode[0]
141+
|| (3 === count($explode) && 'Symfony' === $explode[0] && ('Component' === $explode[1] || 'Config' === $explode[1]))
140142
) {
141143
continue;
142144
}
143145

144-
$classes[$i] = ['class'=>$class, 'line'=>$i+1];
146+
$classes[$i] = ['class' => $class, 'line' => $i + 1];
145147
$fileBody .= sprintf('%s => isLoaded("%s"),', $i, $class)."\n";
146148
}
147149

@@ -158,7 +160,7 @@ function isLoaded($class) {
158160
159161
echo json_encode([ARRAY_CONTENT]);
160162
161-
', ['ARRAY_CONTENT'=>$fileBody]));
163+
', ['ARRAY_CONTENT' => $fileBody]));
162164

163165
$process = new Process(['php', 'class_exist.php'], $applicationDirectory);
164166
$process->run();
@@ -169,7 +171,12 @@ function isLoaded($class) {
169171
}
170172

171173
$output = $process->getOutput();
172-
$results = json_decode($output, true, 512, JSON_THROW_ON_ERROR);
174+
try {
175+
$results = json_decode($output, true, 512, JSON_THROW_ON_ERROR);
176+
} catch (\JsonException $e) {
177+
// TODO handle this
178+
return;
179+
}
173180

174181
foreach ($classes as $i => $classData) {
175182
if (!$results[$i]) {

0 commit comments

Comments
 (0)