[BrowserKit] Improves CookieJar::get

dunglas · dunglas · commit 1cc92d410f51 · 2018-03-16T17:11:50.000+01:00
diff --git a/CookieJar.php b/CookieJar.php
@@ -47,13 +47,13 @@ public function get($name, $path = '/', $domain = null)
             foreach ($this->cookieJar as $cookieDomain => $pathCookies) {
                 if ($cookieDomain) {
                     $cookieDomain = '.'.ltrim($cookieDomain, '.');
-                    if ($cookieDomain != substr('.'.$domain, -strlen($cookieDomain))) {
+                    if ($cookieDomain !== substr('.'.$domain, -\strlen($cookieDomain))) {
                         continue;
                     }
                 }
 
                 foreach ($pathCookies as $cookiePath => $namedCookies) {
-                    if ($cookiePath != substr($path, 0, strlen($cookiePath))) {
+                    if (0 !== strpos($path, $cookiePath)) {
                         continue;
                     }
                     if (isset($namedCookies[$name])) {

Original file line number	Diff line number	Diff line change
`@@ -47,13 +47,13 @@ public function get($name, $path = '/', $domain = null)`
`47`	`47`	`foreach ($this->cookieJar as $cookieDomain => $pathCookies) {`
`48`	`48`	`if ($cookieDomain) {`
`49`	`49`	`$cookieDomain = '.'.ltrim($cookieDomain, '.');`
`50`		`- if ($cookieDomain != substr('.'.$domain, -strlen($cookieDomain))) {`
	`50`	`+ if ($cookieDomain !== substr('.'.$domain, -\strlen($cookieDomain))) {`
`51`	`51`	`continue;`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`foreach ($pathCookies as $cookiePath => $namedCookies) {`
`56`		`- if ($cookiePath != substr($path, 0, strlen($cookiePath))) {`
	`56`	`+ if (0 !== strpos($path, $cookiePath)) {`
`57`	`57`	`continue;`
`58`	`58`	`}`
`59`	`59`	`if (isset($namedCookies[$name])) {`