Skip to content

Commit 50f77fb

Browse files
committed
Merge branch '2.5'
* 2.5: (33 commits) [Validator] Added Swedish translations [Validator] Fixed ExpressionValidator when the validation root is not an object [Validator] Fixed: Made it possible (again) to pass a class name to Validator::validatePropertyValue() Fix incorrect romanian plural translations fix axes handling in Crawler::filterXPath() fix some docblocks Fixed self-reference in 'service_container' service breaks garbage collection (and clone). [Process] Fix tests when pcntl is not available. [DependencyInjection] Roll back changes made to generated files. [Console] Roll back changes made to fixture files. Issue #11489 Added some CA and ES translations [Validator] Added more detailed inline documentation [Validator] Removed information from the violation output if the value is an array, object or resource partially reverted previous commit fixed CS Add point about ConsoleLogger to Console 2.5 changelog [Validator] Fixed failing tests [Validator] CS fixes [FrameworkBundle] Made ConstraintValidatorFactory aware of the legacy validators [Validator] Added extensive test coverage for the constraint validators for the different APIs ... Conflicts: src/Symfony/Component/Validator/Resources/translations/validators.ca.xlf
2 parents a61d4fb + cd2d1e4 commit 50f77fb

File tree

6 files changed

+10
-5
lines changed

6 files changed

+10
-5
lines changed

Application.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -876,6 +876,8 @@ protected function configureIO(InputInterface $input, OutputInterface $output)
876876
* @param OutputInterface $output An Output instance
877877
*
878878
* @return int 0 if everything went fine, or an error code
879+
*
880+
* @throws \Exception when the command being run threw an exception
879881
*/
880882
protected function doRunCommand(Command $command, InputInterface $input, OutputInterface $output)
881883
{

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ CHANGELOG
1313
* deprecated the dialog helper (use the question helper instead)
1414
* deprecated TableHelper in favor of Table
1515
* deprecated ProgressHelper in favor of ProgressBar
16+
* added ConsoleLogger
1617
* added a question helper
1718
* added a way to set the process name of a command
1819
* added a way to set a default command instead of `ListCommand`

Helper/DescriptorHelper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public function __construct()
5454
* @param object $object
5555
* @param array $options
5656
*
57-
* @throws \InvalidArgumentException
57+
* @throws \InvalidArgumentException when the given format is not supported
5858
*/
5959
public function describe(OutputInterface $output, $object, array $options = array())
6060
{

Helper/DialogHelper.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ public function askHiddenResponse(OutputInterface $output, $question, $fallback
328328
* @param OutputInterface $output An Output instance
329329
* @param string|array $question The question to ask
330330
* @param callable $validator A PHP callback
331-
* @param int $attempts Max number of times to ask before giving up (false by default, which means infinite)
331+
* @param int|false $attempts Max number of times to ask before giving up (false by default, which means infinite)
332332
* @param string $default The default answer if none is given by the user
333333
* @param array $autocomplete List of values to autocomplete
334334
*
@@ -357,7 +357,7 @@ public function askAndValidate(OutputInterface $output, $question, $validator, $
357357
* @param OutputInterface $output An Output instance
358358
* @param string|array $question The question to ask
359359
* @param callable $validator A PHP callback
360-
* @param int $attempts Max number of times to ask before giving up (false by default, which means infinite)
360+
* @param int|false $attempts Max number of times to ask before giving up (false by default, which means infinite)
361361
* @param bool $fallback In case the response can not be hidden, whether to fallback on non-hidden question or not
362362
*
363363
* @return string The response
@@ -451,7 +451,7 @@ private function hasSttyAvailable()
451451
* @param callable $interviewer A callable that will ask for a question and return the result
452452
* @param OutputInterface $output An Output instance
453453
* @param callable $validator A PHP callback
454-
* @param int $attempts Max number of times to ask before giving up ; false will ask infinitely
454+
* @param int|false $attempts Max number of times to ask before giving up ; false will ask infinitely
455455
*
456456
* @return string The validated response
457457
*

Helper/TableHelper.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ public function __construct()
4444
* @param int $layout self::LAYOUT_*
4545
*
4646
* @return TableHelper
47+
*
48+
* @throws InvalidArgumentException when the table layout is not known
4749
*/
4850
public function setLayout($layout)
4951
{

Tests/Command/ListCommandTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public function testExecuteListsCommandsWithRawOption()
5050
public function testExecuteListsCommandsWithNamespaceArgument()
5151
{
5252

53-
require_once(realpath(__DIR__.'/../Fixtures/FooCommand.php'));
53+
require_once realpath(__DIR__.'/../Fixtures/FooCommand.php');
5454
$application = new Application();
5555
$application->add(new \FooCommand());
5656
$commandTester = new CommandTester($command = $application->get('list'));

0 commit comments

Comments
 (0)