Move array_merge calls out of loops to improve performance

simonberger · simonberger · commit da98f40de8d8 · 2021-10-04T20:34:22.000+02:00
diff --git a/Application.php b/Application.php
@@ -573,14 +573,14 @@ public function getNamespaces()
                 continue;
             }
 
-            $namespaces = array_merge($namespaces, $this->extractAllNamespaces($command->getName()));
+            $namespaces[] = $this->extractAllNamespaces($command->getName());
 
             foreach ($command->getAliases() as $alias) {
-                $namespaces = array_merge($namespaces, $this->extractAllNamespaces($alias));
+                $namespaces[] = $this->extractAllNamespaces($alias);
             }
         }
 
-        return array_values(array_unique(array_filter($namespaces)));
+        return array_values(array_unique(array_filter(array_merge([], ...$namespaces))));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -573,14 +573,14 @@ public function getNamespaces()`
`573`	`573`	`continue;`
`574`	`574`	`}`
`575`	`575`
`576`		`- $namespaces = array_merge($namespaces, $this->extractAllNamespaces($command->getName()));`
	`576`	`+ $namespaces[] = $this->extractAllNamespaces($command->getName());`
`577`	`577`
`578`	`578`	`foreach ($command->getAliases() as $alias) {`
`579`		`- $namespaces = array_merge($namespaces, $this->extractAllNamespaces($alias));`
	`579`	`+ $namespaces[] = $this->extractAllNamespaces($alias);`
`580`	`580`	`}`
`581`	`581`	`}`
`582`	`582`
`583`		`- return array_values(array_unique(array_filter($namespaces)));`
	`583`	`+ return array_values(array_unique(array_filter(array_merge([], ...$namespaces))));`
`584`	`584`	`}`
`585`	`585`
`586`	`586`	`/**`