Merge branch '4.3' into 4.4

* 4.3: (34 commits)
  [PhpunitBridge] Read environment variable from superglobals
  [Bridge/PhpUnit] Fix PHP5.5 compat
  [PhpUnitBridge] More accurate grouping
  fixed CS
  Extract unrecoverable exception to interface
  [FrameworkBundle] Fix calling Client::getProfile() before sending a request
  Fix type error
  [Security/Core] require libsodium >= 1.0.14
  [Workflow] re-add workflow.definition tag to workflow services
  [Security/Core] Don't use ParagonIE_Sodium_Compat
  revert #30525 due to performance penalty
  collect called listeners information only once
  [Lock] fix missing inherit docs in RedisStore
  [Messenger] fix retrying handlers using DoctrineTransactionMiddleware
  [Mailgun Mailer] fixed issue when using html body
  [HttpClient] fix timing measurements with NativeHttpClient
  [HttpClient] fix dealing with 1xx informational responses
  add test to avoid regressions
  fix mirroring directory into parent directory
  fix typos
  ...

Author: nicolas-grekas

DependencyInjection/DebugExtension.php

@@ -17,6 +17,7 @@
 use Symfony\Component\DependencyInjection\Extension\Extension;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\DependencyInjection\Reference;
+use Symfony\Component\VarDumper\Caster\ReflectionCaster;
 use Symfony\Component\VarDumper\Dumper\CliDumper;
 use Symfony\Component\VarDumper\Dumper\HtmlDumper;
 
@@ -43,9 +44,9 @@ public function load(array $configs, ContainerBuilder $container)
             ->addMethodCall('setMinDepth', [$config['min_depth']])
             ->addMethodCall('setMaxString', [$config['max_string_length']]);
 
-        if (method_exists(ReflectionClass::class, 'unsetClosureFileInfo')) {
+        if (method_exists(ReflectionCaster::class, 'unsetClosureFileInfo')) {
             $container->getDefinition('var_dumper.cloner')
-                ->addMethodCall('addCasters', ReflectionClass::UNSET_CLOSURE_FILE_INFO);
+                ->addMethodCall('addCasters', [ReflectionCaster::UNSET_CLOSURE_FILE_INFO]);
         }
 
         if (method_exists(HtmlDumper::class, 'setTheme') && 'dark' !== $config['theme']) {

Tests/DependencyInjection/DebugExtensionTest.php

@@ -15,6 +15,7 @@
 use Symfony\Bundle\DebugBundle\DependencyInjection\DebugExtension;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\ParameterBag\ParameterBag;
+use Symfony\Component\VarDumper\Caster\ReflectionCaster;
 
 class DebugExtensionTest extends TestCase
 {
@@ -36,6 +37,39 @@ public function testLoadWithoutConfiguration()
         $this->assertSame($expectedTags, $container->getDefinition('data_collector.dump')->getTag('data_collector'));
     }
 
+    public function testUnsetClosureFileInfoShouldBeRegisteredInVarCloner()
+    {
+        if (!method_exists(ReflectionCaster::class, 'unsetClosureFileInfo')) {
+            $this->markTestSkipped('Method not available');
+        }
+
+        $container = $this->createContainer();
+        $container->registerExtension(new DebugExtension());
+        $container->loadFromExtension('debug', []);
+        $this->compileContainer($container);
+
+        $definition = $container->getDefinition('var_dumper.cloner');
+
+        $called = false;
+        foreach ($definition->getMethodCalls() as $call) {
+            if ('addCasters' !== $call[0]) {
+                continue;
+            }
+
+            $argument = $call[1][0] ?? null;
+            if (null === $argument) {
+                continue;
+            }
+
+            if (['Closure' => ReflectionCaster::class.'::unsetClosureFileInfo'] === $argument) {
+                $called = true;
+                break;
+            }
+        }
+
+        $this->assertTrue($called);
+    }
+
     private function createContainer()
     {
         $container = new ContainerBuilder(new ParameterBag([