Skip to content
This repository was archived by the owner on Dec 9, 2023. It is now read-only.

Commit d251523

Browse files
committed
minor #18025 [2.7] Don't use reflection when possible (Ener-Getick)
This PR was merged into the 2.7 branch. Discussion ---------- [2.7] Don't use reflection when possible | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | See symfony/symfony#18021 Commits ------- 35be501 Don't use reflections when possible
2 parents 26527cc + f2e4849 commit d251523

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

DebugClassLoader.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -193,16 +193,16 @@ public function loadClass($class)
193193
break;
194194
}
195195
}
196-
$parent = $refl->getParentClass();
196+
$parent = get_parent_class($class);
197197

198-
if (!$parent || strncmp($ns, $parent->name, $len)) {
199-
if ($parent && isset(self::$deprecated[$parent->name]) && strncmp($ns, $parent->name, $len)) {
200-
@trigger_error(sprintf('The %s class extends %s that is deprecated %s', $name, $parent->name, self::$deprecated[$parent->name]), E_USER_DEPRECATED);
198+
if (!$parent || strncmp($ns, $parent, $len)) {
199+
if ($parent && isset(self::$deprecated[$parent]) && strncmp($ns, $parent, $len)) {
200+
@trigger_error(sprintf('The %s class extends %s that is deprecated %s', $name, $parent, self::$deprecated[$parent]), E_USER_DEPRECATED);
201201
}
202202

203-
foreach ($refl->getInterfaceNames() as $interface) {
204-
if (isset(self::$deprecated[$interface]) && strncmp($ns, $interface, $len) && !($parent && $parent->implementsInterface($interface))) {
205-
@trigger_error(sprintf('The %s %s %s that is deprecated %s', $name, $refl->isInterface() ? 'interface extends' : 'class implements', $interface, self::$deprecated[$interface]), E_USER_DEPRECATED);
203+
foreach (class_implements($class) as $interface) {
204+
if (isset(self::$deprecated[$interface]) && strncmp($ns, $interface, $len) && !is_subclass_of($parent, $interface)) {
205+
@trigger_error(sprintf('The %s %s %s that is deprecated %s', $name, interface_exists($class) ? 'interface extends' : 'class implements', $interface, self::$deprecated[$interface]), E_USER_DEPRECATED);
206206
}
207207
}
208208
}

0 commit comments

Comments
 (0)