Made the slugger compatible with every language

javiereguiluz · javiereguiluz · commit 161b50862feb · 2016-10-14T17:52:26.000+02:00
diff --git a/src/AppBundle/Utils/Slugger.php b/src/AppBundle/Utils/Slugger.php
@@ -27,6 +27,6 @@ class Slugger
      */
     public function slugify($string)
     {
-        return trim(preg_replace('/[^a-z0-9]+/', '-', strtolower(strip_tags($string))), '-');
+        return preg_replace('/\s+/', '-', mb_strtolower(trim(strip_tags($string)), 'UTF-8'));
     }
 }
diff --git a/tests/AppBundle/Utils/SluggerTest.php b/tests/AppBundle/Utils/SluggerTest.php
@@ -38,10 +38,13 @@ public function testSlugify($string, $slug)
 
     public function getSlugs()
     {
-        yield ['Lorem Ipsum'     , 'lorem-ipsum'];
-        yield ['  Lorem Ipsum  ' , 'lorem-ipsum'];
-        yield [' lOrEm  iPsUm  ' , 'lorem-ipsum'];
-        yield ['!Lorem Ipsum!'   , 'lorem-ipsum'];
-        yield ['lorem-ipsum'     , 'lorem-ipsum'];
+        yield ['Lorem Ipsum', 'lorem-ipsum'];
+        yield ['  Lorem Ipsum  ', 'lorem-ipsum'];
+        yield [' lOrEm  iPsUm  ', 'lorem-ipsum'];
+        yield ['!Lorem Ipsum!', '!lorem-ipsum!'];
+        yield ['lorem-ipsum', 'lorem-ipsum'];
+        yield ['lorem 日本語 ipsum', 'lorem-日本語-ipsum'];
+        yield ['lorem русский язык ipsum', 'lorem-русский-язык-ipsum'];
+        yield ['lorem العَرَبِيَّة‎‎ ipsum', 'lorem-العَرَبِيَّة‎‎-ipsum'];
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,6 @@ class Slugger`
`27`	`27`	`*/`
`28`	`28`	`public function slugify($string)`
`29`	`29`	`{`
`30`		`- return trim(preg_replace('/[^a-z0-9]+/', '-', strtolower(strip_tags($string))), '-');`
	`30`	`+ return preg_replace('/\s+/', '-', mb_strtolower(trim(strip_tags($string)), 'UTF-8'));`
`31`	`31`	`}`
`32`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,10 +38,13 @@ public function testSlugify($string, $slug)`
`38`	`38`
`39`	`39`	`public function getSlugs()`
`40`	`40`	`{`
`41`		`- yield ['Lorem Ipsum' , 'lorem-ipsum'];`
`42`		`- yield [' Lorem Ipsum ' , 'lorem-ipsum'];`
`43`		`- yield [' lOrEm iPsUm ' , 'lorem-ipsum'];`
`44`		`- yield ['!Lorem Ipsum!' , 'lorem-ipsum'];`
`45`		`- yield ['lorem-ipsum' , 'lorem-ipsum'];`
	`41`	`+ yield ['Lorem Ipsum', 'lorem-ipsum'];`
	`42`	`+ yield [' Lorem Ipsum ', 'lorem-ipsum'];`
	`43`	`+ yield [' lOrEm iPsUm ', 'lorem-ipsum'];`
	`44`	`+ yield ['!Lorem Ipsum!', '!lorem-ipsum!'];`
	`45`	`+ yield ['lorem-ipsum', 'lorem-ipsum'];`
	`46`	`+ yield ['lorem 日本語 ipsum', 'lorem-日本語-ipsum'];`
	`47`	`+ yield ['lorem русский язык ipsum', 'lorem-русский-язык-ipsum'];`
	`48`	`+ yield ['lorem العَرَبِيَّة‎‎ ipsum', 'lorem-العَرَبِيَّة‎‎-ipsum'];`
`46`	`49`	`}`
`47`	`50`	`}`