Add property types and constructor promotion.

Author: derrabus

config/services.yaml

@@ -15,9 +15,9 @@ services:
         autowire: true      # Automatically injects dependencies in your services.
         autoconfigure: true # Automatically registers your services as commands, event subscribers, etc.
         bind:               # defines the scalar arguments once and apply them to any service defined/created in this file
-            $locales: '%app_locales%'
-            $defaultLocale: '%locale%'
-            $emailSender: '%app.notifications.email_sender%'
+            string $locales: '%app_locales%'
+            string $defaultLocale: '%locale%'
+            string $emailSender: '%app.notifications.email_sender%'
 
     # makes classes in src/ available to be used as services
     # this creates a service per class whose id is the fully-qualified class name

src/Command/AddUserCommand.php

@@ -52,24 +52,15 @@ class AddUserCommand extends Command
     // so it will be instantiated only when the command is actually called.
     protected static $defaultName = 'app:add-user';
 
-    /**
-     * @var SymfonyStyle
-     */
-    private $io;
-
-    private $entityManager;
-    private $passwordEncoder;
-    private $validator;
-    private $users;
-
-    public function __construct(EntityManagerInterface $em, UserPasswordEncoderInterface $encoder, Validator $validator, UserRepository $users)
-    {
+    private SymfonyStyle $io;
+
+    public function __construct(
+        private EntityManagerInterface $entityManager,
+        private UserPasswordEncoderInterface $passwordEncoder,
+        private Validator $validator,
+        private UserRepository $users
+    ) {
         parent::__construct();
-
-        $this->entityManager = $em;
-        $this->passwordEncoder = $encoder;
-        $this->validator = $validator;
-        $this->users = $users;
     }
 
     /**

src/Command/DeleteUserCommand.php

@@ -41,19 +41,14 @@ class DeleteUserCommand extends Command
 {
     protected static $defaultName = 'app:delete-user';
 
-    /** @var SymfonyStyle */
-    private $io;
-    private $entityManager;
-    private $validator;
-    private $users;
+    private SymfonyStyle $io;
 
-    public function __construct(EntityManagerInterface $em, Validator $validator, UserRepository $users)
-    {
+    public function __construct(
+        private EntityManagerInterface $entityManager,
+        private Validator $validator,
+        private UserRepository $users
+    ) {
         parent::__construct();
-
-        $this->entityManager = $em;
-        $this->validator = $validator;
-        $this->users = $users;
     }
 
     /**

src/Command/ListUsersCommand.php

@@ -42,17 +42,12 @@ class ListUsersCommand extends Command
     // a good practice is to use the 'app:' prefix to group all your custom application commands
     protected static $defaultName = 'app:list-users';
 
-    private $mailer;
-    private $emailSender;
-    private $users;
-
-    public function __construct(MailerInterface $mailer, $emailSender, UserRepository $users)
-    {
+    public function __construct(
+        private MailerInterface $mailer,
+        private string $emailSender,
+        private UserRepository $users
+    ) {
         parent::__construct();
-
-        $this->mailer = $mailer;
-        $this->emailSender = $emailSender;
-        $this->users = $users;
     }
 
     /**

src/DataFixtures/AppFixtures.php

@@ -23,13 +23,10 @@
 
 class AppFixtures extends Fixture
 {
-    private $passwordEncoder;
-    private $slugger;
-
-    public function __construct(UserPasswordEncoderInterface $passwordEncoder, SluggerInterface $slugger)
-    {
-        $this->passwordEncoder = $passwordEncoder;
-        $this->slugger = $slugger;
+    public function __construct(
+        private UserPasswordEncoderInterface $passwordEncoder,
+        private SluggerInterface $slugger
+    ) {
     }
 
     public function load(ObjectManager $manager): void

src/Entity/Comment.php

@@ -31,25 +31,19 @@
 class Comment
 {
     /**
-     * @var int
-     *
      * @ORM\Id
      * @ORM\GeneratedValue
      * @ORM\Column(type="integer")
      */
-    private $id;
+    private ?int $id = null;
 
     /**
-     * @var Post
-     *
      * @ORM\ManyToOne(targetEntity="Post", inversedBy="comments")
      * @ORM\JoinColumn(nullable=false)
      */
-    private $post;
+    private ?Post $post = null;
 
     /**
-     * @var string
-     *
      * @ORM\Column(type="text")
      */
     #[
@@ -61,22 +55,18 @@ class Comment
             maxMessage: 'comment.too_long',
         )
     ]
-    private $content;
+    private ?string $content = null;
 
     /**
-     * @var \DateTime
-     *
      * @ORM\Column(type="datetime")
      */
-    private $publishedAt;
+    private \DateTime $publishedAt;
 
     /**
-     * @var User
-     *
      * @ORM\ManyToOne(targetEntity="App\Entity\User")
      * @ORM\JoinColumn(nullable=false)
      */
-    private $author;
+    private ?User $author = null;
 
     public function __construct()
     {

src/Entity/Post.php

@@ -36,39 +36,31 @@
 class Post
 {
     /**
-     * @var int
-     *
      * @ORM\Id
      * @ORM\GeneratedValue
      * @ORM\Column(type="integer")
      */
-    private $id;
+    private ?int $id = null;
 
     /**
-     * @var string
-     *
      * @ORM\Column(type="string")
      */
     #[Assert\NotBlank]
-    private $title;
+    private ?string $title = null;
 
     /**
-     * @var string
-     *
      * @ORM\Column(type="string")
      */
-    private $slug;
+    private ?string $slug = null;
 
     /**
-     * @var string
-     *
      * @ORM\Column(type="string")
      */
     #[
         Assert\NotBlank(message: 'post.blank_summary'),
-        Assert\Length(max: 255),
+        Assert\Length(max: 255)
     ]
-    private $summary;
+    private ?string $summary = null;
 
     /**
      * @var string
@@ -79,25 +71,21 @@ class Post
         Assert\NotBlank(message: 'post.blank_content'),
         Assert\Length(min: 10, minMessage: 'post.too_short_content')
     ]
-    private $content;
+    private ?string $content = null;
 
     /**
-     * @var \DateTime
-     *
      * @ORM\Column(type="datetime")
      */
-    private $publishedAt;
+    private \DateTime $publishedAt;
 
     /**
-     * @var User
-     *
      * @ORM\ManyToOne(targetEntity="App\Entity\User")
      * @ORM\JoinColumn(nullable=false)
      */
-    private $author;
+    private ?User $author = null;
 
     /**
-     * @var Comment[]|ArrayCollection
+     * @var Comment[]|Collection
      *
      * @ORM\OneToMany(
      *      targetEntity="Comment",
@@ -107,17 +95,17 @@ class Post
      * )
      * @ORM\OrderBy({"publishedAt": "DESC"})
      */
-    private $comments;
+    private Collection $comments;
 
     /**
-     * @var Tag[]|ArrayCollection
+     * @var Tag[]|Collection
      *
      * @ORM\ManyToMany(targetEntity="App\Entity\Tag", cascade={"persist"})
      * @ORM\JoinTable(name="symfony_demo_post_tag")
      * @ORM\OrderBy({"name": "ASC"})
      */
     #[Assert\Count(max: 4, maxMessage: 'post.too_many_tags')]
-    private $tags;
+    private Collection $tags;
 
     public function __construct()
     {

src/Entity/Tag.php

@@ -26,20 +26,16 @@
 class Tag implements \JsonSerializable
 {
     /**
-     * @var int
-     *
      * @ORM\Id
      * @ORM\GeneratedValue
      * @ORM\Column(type="integer")
      */
-    private $id;
+    private ?int $id = null;
 
     /**
-     * @var string
-     *
      * @ORM\Column(type="string", unique=true)
      */
-    private $name;
+    private ?string $name = null;
 
     public function getId(): ?int
     {

src/Entity/User.php

@@ -31,54 +31,42 @@
 class User implements UserInterface, \Serializable
 {
     /**
-     * @var int
-     *
      * @ORM\Id
      * @ORM\GeneratedValue
      * @ORM\Column(type="integer")
      */
-    private $id;
+    private ?int $id = null;
 
     /**
-     * @var string
-     *
      * @ORM\Column(type="string")
      */
     #[Assert\NotBlank]
-    private $fullName;
+    private ?string $fullName = null;
 
     /**
-     * @var string
-     *
      * @ORM\Column(type="string", unique=true)
      */
     #[
         Assert\NotBlank,
         Assert\Length(min: 2, max: 50)
     ]
-    private $username;
+    private ?string $username = null;
 
     /**
-     * @var string
-     *
      * @ORM\Column(type="string", unique=true)
      */
     #[Assert\Email]
-    private $email;
+    private ?string $email = null;
 
     /**
-     * @var string
-     *
      * @ORM\Column(type="string")
      */
-    private $password;
+    private ?string $password = null;
 
     /**
-     * @var array
-     *
      * @ORM\Column(type="json")
      */
-    private $roles = [];
+    private array $roles = [];
 
     public function getId(): ?int
     {

src/Event/CommentCreatedEvent.php

@@ -16,11 +16,9 @@
 
 class CommentCreatedEvent extends Event
 {
-    protected $comment;
-
-    public function __construct(Comment $comment)
-    {
-        $this->comment = $comment;
+    public function __construct(
+        protected Comment $comment
+    ) {
     }
 
     public function getComment(): Comment

src/EventSubscriber/CheckRequirementsSubscriber.php

@@ -30,11 +30,9 @@
  */
 class CheckRequirementsSubscriber implements EventSubscriberInterface
 {
-    private $entityManager;
-
-    public function __construct(EntityManagerInterface $entityManager)
-    {
-        $this->entityManager = $entityManager;
+    public function __construct(
+        private EntityManagerInterface $entityManager
+    ) {
     }
 
     // Event Subscribers must define this method to declare the events they