Improve the checking if the current request is a master request in the ControllerListener. #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e ControllerListener
|
@voronkovich thanks for this improvement. I do agree with you that this proposal is much better. You don't need to know the internal Symfony details when you are learning Symfony. In any case, before merging it, I'll wait a bit so others can comment if they don't agree or see some drawback. Cheers! |
|
I agree with it because it's more readable and less "frigthening" for beginners. |
|
👍 |
|
@voronkovich thanks for helping us improve the code of the Symfony Demo application! |
javiereguiluz
added a commit
that referenced
this pull request
May 26, 2015
…uest in the ControllerListener. (voronkovich) This PR was merged into the master branch. Discussion ---------- Improve the checking if the current request is a master request in the ControllerListener. There is a more convenient way to check whether the current request is a master request. See http://api.symfony.com/2.7/Symfony/Component/HttpKernel/Event/KernelEvent.html#method_isMasterRequest Commits ------- a90021f Improve the checking if the current request is a master request in the ControllerListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a more convenient way to check whether the current request is a master request. See http://api.symfony.com/2.7/Symfony/Component/HttpKernel/Event/KernelEvent.html#method_isMasterRequest