[DI] fix dumping deprecated private aliases

nicolas-grekas · nicolas-grekas · commit 31d826329307 · 2020-06-21T18:08:20.000+02:00
diff --git a/Dumper/YamlDumper.php b/Dumper/YamlDumper.php
@@ -163,8 +163,8 @@ private function addServiceAlias(string $alias, Alias $id): string
     {
         $deprecated = $id->isDeprecated() ? sprintf("        deprecated: %s\n", $id->getDeprecationMessage('%alias_id%')) : '';
 
-        if ($id->isPrivate()) {
-            return sprintf("    %s: '@%s'\n%s", $alias, $id, $deprecated);
+        if (!$id->isDeprecated() && $id->isPrivate()) {
+            return sprintf("    %s: '@%s'\n", $alias, $id);
         }
 
         return sprintf("    %s:\n        alias: %s\n        public: %s\n%s", $alias, $id, $id->isPublic() ? 'true' : 'false', $deprecated);

Original file line number	Diff line number	Diff line change
`@@ -163,8 +163,8 @@ private function addServiceAlias(string $alias, Alias $id): string`
`163`	`163`	`{`
`164`	`164`	`$deprecated = $id->isDeprecated() ? sprintf(" deprecated: %s\n", $id->getDeprecationMessage('%alias_id%')) : '';`
`165`	`165`
`166`		`- if ($id->isPrivate()) {`
`167`		`- return sprintf(" %s: '@%s'\n%s", $alias, $id, $deprecated);`
	`166`	`+ if (!$id->isDeprecated() && $id->isPrivate()) {`
	`167`	`+ return sprintf(" %s: '@%s'\n", $alias, $id);`
`168`	`168`	`}`
`169`	`169`
`170`	`170`	`return sprintf(" %s:\n alias: %s\n public: %s\n%s", $alias, $id, $id->isPublic() ? 'true' : 'false', $deprecated);`