Skip to content

Commit 3beb848

Browse files
Make PHP 8 green on Travis
1 parent 70c71fe commit 3beb848

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed

Tests/Compiler/AutowirePassTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
use Symfony\Component\DependencyInjection\Reference;
2424
use Symfony\Component\DependencyInjection\Tests\Fixtures\CaseSensitiveClass;
2525
use Symfony\Component\DependencyInjection\Tests\Fixtures\includes\FooVariadic;
26+
use Symfony\Component\DependencyInjection\Tests\Fixtures\includes\MultipleArgumentsOptionalScalarNotReallyOptional;
2627
use Symfony\Component\DependencyInjection\TypedReference;
2728

2829
require_once __DIR__.'/../Fixtures/includes/autowiring_classes.php';
@@ -473,6 +474,9 @@ public function testNoTypeArgsCannotBeAutowired()
473474
(new AutowirePass())->process($container);
474475
}
475476

477+
/**
478+
* @requires PHP < 8
479+
*/
476480
public function testOptionalScalarNotReallyOptionalUsesDefaultValue()
477481
{
478482
$container = new ContainerBuilder();
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<?php
2+
3+
namespace Symfony\Component\DependencyInjection\Tests\Fixtures\includes;
4+
5+
use Symfony\Component\DependencyInjection\Tests\Compiler\A;
6+
use Symfony\Component\DependencyInjection\Tests\Compiler\Lille;
7+
8+
class MultipleArgumentsOptionalScalarNotReallyOptional
9+
{
10+
public function __construct(A $a, $foo = 'default_val', Lille $lille)
11+
{
12+
}
13+
}
14+

Tests/Fixtures/includes/autowiring_classes.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -184,12 +184,6 @@ public function __construct(A $a, Lille $lille, $foo = 'some_val')
184184
{
185185
}
186186
}
187-
class MultipleArgumentsOptionalScalarNotReallyOptional
188-
{
189-
public function __construct(A $a, $foo = 'default_val', Lille $lille)
190-
{
191-
}
192-
}
193187

194188
/*
195189
* Classes used for testing createResourceForClass

0 commit comments

Comments
 (0)