Skip to content

Commit 57d314a

Browse files
committed
fix some risky tests
1 parent d2c2c05 commit 57d314a

6 files changed

+24
-0
lines changed

Tests/Compiler/CheckCircularReferencesPassTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,8 @@ public function testProcessIgnoresMethodCalls()
114114
$container->register('b')->addMethodCall('setA', array(new Reference('a')));
115115

116116
$this->process($container);
117+
118+
$this->addToAssertionCount(1);
117119
}
118120

119121
protected function process(ContainerBuilder $container)

Tests/Compiler/CheckDefinitionValidityPassTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ public function testProcess()
7272
$container->register('d', 'class')->setSynthetic(true);
7373

7474
$this->process($container);
75+
76+
$this->addToAssertionCount(1);
7577
}
7678

7779
public function testValidTags()
@@ -83,6 +85,8 @@ public function testValidTags()
8385
$container->register('d', 'class')->addTag('foo', array('bar' => 1.1));
8486

8587
$this->process($container);
88+
89+
$this->addToAssertionCount(1);
8690
}
8791

8892
/**

Tests/Compiler/CheckExceptionOnInvalidReferenceBehaviorPassTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ public function testProcess()
2828
->addArgument(new Reference('b'))
2929
;
3030
$container->register('b', '\stdClass');
31+
32+
$this->process($container);
33+
34+
$this->addToAssertionCount(1);
3135
}
3236

3337
/**

Tests/Compiler/CheckReferenceValidityPassTest.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ public function testProcessIgnoresScopeWideningIfNonStrictReference()
2727
$container->register('b')->setScope('prototype');
2828

2929
$this->process($container);
30+
31+
$this->addToAssertionCount(1);
3032
}
3133

3234
/**
@@ -39,6 +41,8 @@ public function testProcessDetectsScopeWidening()
3941
$container->register('b')->setScope('prototype');
4042

4143
$this->process($container);
44+
45+
$this->addToAssertionCount(1);
4246
}
4347

4448
public function testProcessIgnoresCrossScopeHierarchyReferenceIfNotStrict()
@@ -51,6 +55,8 @@ public function testProcessIgnoresCrossScopeHierarchyReferenceIfNotStrict()
5155
$container->register('b')->setScope('b');
5256

5357
$this->process($container);
58+
59+
$this->addToAssertionCount(1);
5460
}
5561

5662
/**
@@ -88,6 +94,8 @@ public function testProcess()
8894
$container->register('b');
8995

9096
$this->process($container);
97+
98+
$this->addToAssertionCount(1);
9199
}
92100

93101
protected function process(ContainerBuilder $container)

Tests/Dumper/PhpDumperTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,8 @@ public function testCircularReferenceAllowanceForLazyServices()
297297

298298
$dumper = new PhpDumper($container);
299299
$dumper->dump();
300+
301+
$this->addToAssertionCount(1);
300302
}
301303

302304
public function testCircularReferenceAllowanceForInlinedDefinitionsForLazyServices()
@@ -334,5 +336,7 @@ public function testCircularReferenceAllowanceForInlinedDefinitionsForLazyServic
334336

335337
$dumper->setProxyDumper(new DummyProxyDumper());
336338
$dumper->dump();
339+
340+
$this->addToAssertionCount(1);
337341
}
338342
}

Tests/Dumper/XmlDumperTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,8 @@ public function testCompiledContainerCanBeDumped($containerFile)
162162
$container->compile();
163163
$dumper = new XmlDumper($container);
164164
$dumper->dump();
165+
166+
$this->addToAssertionCount(1);
165167
}
166168

167169
public function provideCompiledContainerData()

0 commit comments

Comments
 (0)