Skip to content

Commit 79809e8

Browse files
Dont call sprintf() when no placeholders are used
1 parent 65f54e5 commit 79809e8

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Definition.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ public function setMethodCalls(array $calls = array())
373373
public function addMethodCall($method, array $arguments = array())
374374
{
375375
if (empty($method)) {
376-
throw new InvalidArgumentException(sprintf('Method name cannot be empty.'));
376+
throw new InvalidArgumentException('Method name cannot be empty.');
377377
}
378378
$this->calls[] = array($method, $arguments);
379379

Dumper/YamlDumper.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,19 +93,19 @@ private function addService($id, $definition)
9393
}
9494

9595
if ($definition->isSynthetic()) {
96-
$code .= sprintf(" synthetic: true\n");
96+
$code .= " synthetic: true\n";
9797
}
9898

9999
if ($definition->isSynchronized(false)) {
100-
$code .= sprintf(" synchronized: true\n");
100+
$code .= " synchronized: true\n";
101101
}
102102

103103
if ($definition->getFactoryClass(false)) {
104104
$code .= sprintf(" factory_class: %s\n", $this->dumper->dump($definition->getFactoryClass(false)));
105105
}
106106

107107
if ($definition->isLazy()) {
108-
$code .= sprintf(" lazy: true\n");
108+
$code .= " lazy: true\n";
109109
}
110110

111111
if ($definition->getFactoryMethod(false)) {

0 commit comments

Comments
 (0)