Skip to content

Commit 7f34aa2

Browse files
minor #22818 [DependencyInjection] prepare for signature change in 4.0 (xabbuh)
This PR was submitted for the 3.4 branch but it was merged into the 3.3 branch instead (closes #22818). Discussion ---------- [DependencyInjection] prepare for signature change in 4.0 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | see failing tests in #22785 Commits ------- c4b6e20 [DI] prepare for signature change in 4.0
2 parents fa2e028 + 97a5053 commit 7f34aa2

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

LazyProxy/PhpDumper/NullDumper.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
* Null dumper, negates any proxy code generation for any given service definition.
1818
*
1919
* @author Marco Pivetta <[email protected]>
20+
*
21+
* @final since version 3.3
2022
*/
2123
class NullDumper implements DumperInterface
2224
{
@@ -31,7 +33,7 @@ public function isProxyCandidate(Definition $definition)
3133
/**
3234
* {@inheritdoc}
3335
*/
34-
public function getProxyFactoryCode(Definition $definition, $id)
36+
public function getProxyFactoryCode(Definition $definition, $id, $methodName = null)
3537
{
3638
return '';
3739
}

Tests/Fixtures/includes/classes.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public function isProxyCandidate(Definition $definition)
8888
return false;
8989
}
9090

91-
public function getProxyFactoryCode(Definition $definition, $id)
91+
public function getProxyFactoryCode(Definition $definition, $id, $methodName = null)
9292
{
9393
return '';
9494
}

0 commit comments

Comments
 (0)