Add remaining missing return types to safe methods

wouterj · nicolas-grekas · commit 7b28b8c1ee05 · 2023-04-24T16:22:26.000+02:00
diff --git a/ErrorHandler.php b/ErrorHandler.php
@@ -483,7 +483,7 @@ public function handleError(int $type, string $message, string $file, int $line)
      *
      * @internal
      */
-    public function handleException(\Throwable $exception)
+    public function handleException(\Throwable $exception): void
     {
         $handlerException = null;
 
@@ -534,7 +534,9 @@ public function handleException(\Throwable $exception)
 
         try {
             if (null !== $exceptionHandler) {
-                return $exceptionHandler($exception);
+                $exceptionHandler($exception);
+
+                return;
             }
             $handlerException ??= $exception;
         } catch (\Throwable $handlerException) {

Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,7 @@ public function handleError(int $type, string $message, string $file, int $line)`
`483`	`483`	`*`
`484`	`484`	`* @internal`
`485`	`485`	`*/`
`486`		`- public function handleException(\Throwable $exception)`
	`486`	`+ public function handleException(\Throwable $exception): void`
`487`	`487`	`{`
`488`	`488`	`$handlerException = null;`
`489`	`489`
`@@ -534,7 +534,9 @@ public function handleException(\Throwable $exception)`
`534`	`534`
`535`	`535`	`try {`
`536`	`536`	`if (null !== $exceptionHandler) {`
`537`		`- return $exceptionHandler($exception);`
	`537`	`+ $exceptionHandler($exception);`
	`538`	`+`
	`539`	`+ return;`
`538`	`540`	`}`
`539`	`541`	`$handlerException ??= $exception;`
`540`	`542`	`} catch (\Throwable $handlerException) {`