Skip to content

Commit 3dcbd3c

Browse files
Merge branch '5.2' into 5.3
* 5.2: CS fix Missing translations from traits Fix SkippedTestSuite [Console] Fix type annotation on InputInterface::hasArgument() Revert "minor #41949 [Console] fix type annotations on InputInterface (nicolas-grekas)" [EventDispatcher] Correct the called event listener method case Add missing translations for Japanese. Revert "bug #41952 [Console] fix handling positional arguments (nicolas-grekas)" fix backport
2 parents 2fb9b9a + 457701b commit 3dcbd3c

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

DependencyInjection/RegisterListenersPass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public function process(ContainerBuilder $container)
102102

103103
if (!isset($event['method'])) {
104104
$event['method'] = 'on'.preg_replace_callback([
105-
'/(?<=\b)[a-z]/i',
105+
'/(?<=\b|_)[a-z]/i',
106106
'/[^a-z0-9]/i',
107107
], function ($matches) { return strtoupper($matches[0]); }, $event['event']);
108108
$event['method'] = preg_replace('/[^a-z0-9]/i', '', $event['method']);

Tests/DependencyInjection/RegisterListenersPassTest.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ public function testInvokableEventListener()
203203
$container->register('foo', \stdClass::class)->addTag('kernel.event_listener', ['event' => 'foo.bar']);
204204
$container->register('bar', InvokableListenerService::class)->addTag('kernel.event_listener', ['event' => 'foo.bar']);
205205
$container->register('baz', InvokableListenerService::class)->addTag('kernel.event_listener', ['event' => 'event']);
206+
$container->register('zar', \stdClass::class)->addTag('kernel.event_listener', ['event' => 'foo.bar_zar']);
206207
$container->register('event_dispatcher', \stdClass::class);
207208

208209
$registerListenersPass = new RegisterListenersPass();
@@ -234,6 +235,14 @@ public function testInvokableEventListener()
234235
0,
235236
],
236237
],
238+
[
239+
'addListener',
240+
[
241+
'foo.bar_zar',
242+
[new ServiceClosureArgument(new Reference('zar')), 'onFooBarZar'],
243+
0,
244+
],
245+
],
237246
];
238247
$this->assertEquals($expectedCalls, $definition->getMethodCalls());
239248
}

0 commit comments

Comments
 (0)