Skip to content

Commit f1b75e0

Browse files
minor #32800 Improve some URLs (Arman-Hosseini)
This PR was squashed before being merged into the 3.4 branch (closes #32800). Discussion ---------- Improve some URLs | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- fab17a4487 Improve some URLs
2 parents 00f360d + 87e6a90 commit f1b75e0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Filesystem.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public function copy($originFile, $targetFile, $overwriteNewerFiles = false)
5252
}
5353

5454
if ($doCopy) {
55-
// https://bugs.php.net/bug.php?id=64634
55+
// https://bugs.php.net/64634
5656
if (false === $source = @fopen($originFile, 'r')) {
5757
throw new IOException(sprintf('Failed to copy "%s" to "%s" because source file could not be opened for reading.', $originFile, $targetFile), 0, null, $originFile);
5858
}
@@ -280,7 +280,7 @@ public function rename($origin, $target, $overwrite = false)
280280

281281
if (true !== @rename($origin, $target)) {
282282
if (is_dir($origin)) {
283-
// See https://bugs.php.net/bug.php?id=54097 & http://php.net/manual/en/function.rename.php#113943
283+
// See https://bugs.php.net/54097 & https://php.net/rename#113943
284284
$this->mirror($origin, $target, null, ['override' => $overwrite, 'delete' => $overwrite]);
285285
$this->remove($origin);
286286

Tests/FilesystemTestCase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ protected function markAsSkippedIfSymlinkIsMissing($relative = false)
144144
$this->markTestSkipped('symlink requires "Create symbolic links" privilege on Windows');
145145
}
146146

147-
// https://bugs.php.net/bug.php?id=69473
147+
// https://bugs.php.net/69473
148148
if ($relative && '\\' === \DIRECTORY_SEPARATOR && 1 === PHP_ZTS) {
149149
$this->markTestSkipped('symlink does not support relative paths on thread safe Windows PHP versions');
150150
}

0 commit comments

Comments
 (0)