Merge branch '4.4' into 5.1

fabpot · fabpot · commit f7b9ed6142a3 · 2020-08-21T19:19:47.000+02:00
* 4.4:
  fix passing arguments to call_user_func_array() on PHP 8
  allow Doctrine DBAL 3
  [Filesystem] fix test on PHP 8
diff --git a/Filesystem.php b/Filesystem.php
@@ -194,7 +194,7 @@ public function remove($files)
     public function chmod($files, int $mode, int $umask = 0000, bool $recursive = false)
     {
         foreach ($this->toIterable($files) as $file) {
-            if (true !== @chmod($file, $mode & ~$umask)) {
+            if ((\PHP_VERSION_ID < 80000 || \is_int($mode)) && true !== @chmod($file, $mode & ~$umask)) {
                 throw new IOException(sprintf('Failed to chmod file "%s".', $file), 0, null, $file);
             }
             if ($recursive && is_dir($file) && !is_link($file)) {

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ public function remove($files)`
`194`	`194`	`public function chmod($files, int $mode, int $umask = 0000, bool $recursive = false)`
`195`	`195`	`{`
`196`	`196`	`foreach ($this->toIterable($files) as $file) {`
`197`		`- if (true !== @chmod($file, $mode & ~$umask)) {`
	`197`	`+ if ((\PHP_VERSION_ID < 80000 \|\| \is_int($mode)) && true !== @chmod($file, $mode & ~$umask)) {`
`198`	`198`	`throw new IOException(sprintf('Failed to chmod file "%s".', $file), 0, null, $file);`
`199`	`199`	`}`
`200`	`200`	`if ($recursive && is_dir($file) && !is_link($file)) {`