Use typed properties in tests as much as possible

Author: nicolas-grekas

Tests/Iterator/Iterator.php

@@ -13,7 +13,7 @@
 
 class Iterator implements \Iterator
 {
-    protected $values = [];
+    protected array $values = [];
 
     public function __construct(array $values = [])
     {

Tests/Iterator/MockSplFileInfo.php

@@ -17,11 +17,11 @@ class MockSplFileInfo extends \SplFileInfo
     public const TYPE_FILE = 2;
     public const TYPE_UNKNOWN = 3;
 
-    private $contents;
-    private $mode;
-    private $type;
-    private $relativePath;
-    private $relativePathname;
+    private ?string $contents = null;
+    private ?string $mode = null;
+    private ?int $type = null;
+    private ?string $relativePath = null;
+    private ?string $relativePathname = null;
 
     public function __construct($param)
     {

Tests/Iterator/RealIteratorTestCase.php

@@ -16,8 +16,8 @@
 
 abstract class RealIteratorTestCase extends IteratorTestCase
 {
-    protected static $tmpDir;
-    protected static $files;
+    protected static string $tmpDir;
+    protected static array $files;
 
     public static function setUpBeforeClass(): void
     {
@@ -126,9 +126,7 @@ protected static function toAbsolute($files = null)
         /*
          * Without the call to setUpBeforeClass() property can be null.
          */
-        if (!self::$tmpDir) {
-            self::$tmpDir = realpath(sys_get_temp_dir()).\DIRECTORY_SEPARATOR.'symfony_finder';
-        }
+        self::$tmpDir ??= realpath(sys_get_temp_dir()).\DIRECTORY_SEPARATOR.'symfony_finder';
 
         if (\is_array($files)) {
             $f = [];

Tests/Iterator/VcsIgnoredFilterIteratorTest.php

@@ -16,10 +16,7 @@
 
 class VcsIgnoredFilterIteratorTest extends IteratorTestCase
 {
-    /**
-     * @var string
-     */
-    private $tmpDir;
+    private string $tmpDir;
 
     protected function setUp(): void
     {