feature #656 Unpack by default when running composer require (nicolas-grekas)

This PR was merged into the 1.8-dev branch.

Discussion
----------

Unpack by default when running composer require

Packs are like meta-recipes: ppl should adopt them in their root composer.json so that updating packs (like updating recipes) doesn't affect their project.

If one needs to delegate the selection of a group of packages, they should use the `meta-package` type of composer instead.

Fixes #645

Commits
-------

f7df17b Unpack by default when running composer require

Author: fabpot

src/Command/RequireCommand.php

@@ -32,19 +32,19 @@ public function __construct(PackageResolver $resolver)
     protected function configure()
     {
         parent::configure();
-        $this->addOption('unpack', null, InputOption::VALUE_NONE, 'Unpack Symfony packs in composer.json.');
+        $this->addOption('no-unpack', null, InputOption::VALUE_NONE, 'Disable unpacking Symfony packs in composer.json.');
+        $this->addOption('unpack', null, InputOption::VALUE_NONE, '[DEPRECATED] Unpacking is now enabled by default.');
     }
 
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        $unpack = $input->getOption('unpack');
+        if ($input->getOption('unpack')) {
+            $this->getIO()->writeError('<warning>The "--unpack" command line option is deprecated; unpacking is now enabled by default.</warning>');
+        }
+
         $packages = $this->resolver->resolve($input->getArgument('packages'), true);
         if ($packages) {
             $input->setArgument('packages', $this->resolver->resolve($input->getArgument('packages'), true));
-        } elseif ($unpack) {
-            $this->getIO()->writeError('<error>--unpack is incompatible with the interactive mode.</>');
-
-            return 1;
         }
 
         if (version_compare('2.0.0', PluginInterface::PLUGIN_API_VERSION, '>') && $input->hasOption('no-suggest')) {
@@ -53,7 +53,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         $ret = parent::execute($input, $output) ?? 0;
 
-        if (0 !== $ret || $input->getOption('no-update')) {
+        if (0 !== $ret || $input->getOption('no-unpack') || $input->getOption('no-update')) {
             return $ret;
         }