compare data before marking lock as changed

stlrnz · nicolas-grekas · commit bc400be6a6cd · 2019-12-13T15:34:22.000+01:00
diff --git a/src/Lock.php b/src/Lock.php
@@ -49,14 +49,18 @@ public function get($name)
 
     public function set($name, $data)
     {
-        $this->lock[$name] = $data;
-        $this->changed = true;
+        if (!\array_key_exists($name, $this->lock) || $data !== $this->lock[$name]) {
+            $this->lock[$name] = $data;
+            $this->changed = true;
+        }
     }
 
     public function remove($name)
     {
-        unset($this->lock[$name]);
-        $this->changed = true;
+        if (\array_key_exists($name, $this->lock)) {
+            unset($this->lock[$name]);
+            $this->changed = true;
+        }
     }
 
     public function write()

Original file line number	Diff line number	Diff line change
`@@ -49,14 +49,18 @@ public function get($name)`
`49`	`49`
`50`	`50`	`public function set($name, $data)`
`51`	`51`	`{`
`52`		`- $this->lock[$name] = $data;`
`53`		`- $this->changed = true;`
	`52`	`+ if (!\array_key_exists($name, $this->lock) \|\| $data !== $this->lock[$name]) {`
	`53`	`+ $this->lock[$name] = $data;`
	`54`	`+ $this->changed = true;`
	`55`	`+ }`
`54`	`56`	`}`
`55`	`57`
`56`	`58`	`public function remove($name)`
`57`	`59`	`{`
`58`		`- unset($this->lock[$name]);`
`59`		`- $this->changed = true;`
	`60`	`+ if (\array_key_exists($name, $this->lock)) {`
	`61`	`+ unset($this->lock[$name]);`
	`62`	`+ $this->changed = true;`
	`63`	`+ }`
`60`	`64`	`}`
`61`	`65`
`62`	`66`	`public function write()`