Skip to content

Commit ef8b60e

Browse files
committed
minor #454 Remove non-implemented feature (fabpot)
This PR was merged into the 1.1-dev branch. Discussion ---------- Remove non-implemented feature Commits ------- c9048c3 removed non-implemented feature
2 parents 4a7cd6d + c9048c3 commit ef8b60e

File tree

3 files changed

+3
-15
lines changed

3 files changed

+3
-15
lines changed

src/Downloader.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,6 @@ public function getRecipes(array $operations): array
141141
foreach ($body['manifests'] as $name => $manifest) {
142142
$data['manifests'][$name] = $manifest;
143143
}
144-
foreach ($body['vulnerabilities'] as $name => $vulns) {
145-
$data['vulnerabilities'][$name] = $vulns;
146-
}
147144
foreach ($body['locks'] ?? [] as $name => $lock) {
148145
$data['locks'][$name] = $lock;
149146
}

src/Flex.php

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -298,15 +298,7 @@ public function update(Event $event, $operations = [])
298298
copy(getcwd().'/.env.dist', getcwd().'/.env');
299299
}
300300

301-
list($recipes, $vulnerabilities) = $this->fetchRecipes();
302-
if ($vulnerabilities) {
303-
$this->io->writeError(sprintf('<info>Vulnerabilities: %d package%s</>', \count($vulnerabilities), \count($recipes) > 1 ? 's' : ''));
304-
}
305-
foreach ($vulnerabilities as $name => $vulns) {
306-
foreach ($vulns as $v) {
307-
$this->io->writeError(sprintf(' - <error>Vulnerability on %s</>: %s', $name, $v));
308-
}
309-
}
301+
$recipes = $this->fetchRecipes();
310302

311303
if (2 === $this->displayThanksReminder) {
312304
$love = '\\' === \DIRECTORY_SEPARATOR ? 'love' : '💖 ';
@@ -573,7 +565,7 @@ private function fetchRecipes(): array
573565
if (null === $this->downloader->getEndpoint()) {
574566
$this->io->writeError('<warning>Symfony recipes are disabled: "symfony/flex" not found in the root composer.json</warning>');
575567

576-
return [[], []];
568+
return [];
577569
}
578570
$devPackages = null;
579571
$data = $this->downloader->getRecipes($this->operations);
@@ -624,7 +616,7 @@ private function fetchRecipes(): array
624616
}
625617
$this->operations = [];
626618

627-
return [array_filter($recipes), $data['vulnerabilities'] ?? []];
619+
return array_filter($recipes);
628620
}
629621

630622
private function initOptions(): Options

tests/FlexTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ public function testPostInstall()
5353
'origin' => 'dummy/dummy:[email protected]/symfony/recipes:master',
5454
],
5555
],
56-
'vulnerabilities' => [],
5756
];
5857

5958
$configurator = $this->getMockBuilder(Configurator::class)->disableOriginalConstructor()->getMock();

0 commit comments

Comments
 (0)