Use ::class keyword when possible

Author: fabpot

Extension/Core/Type/ChoiceType.php

@@ -352,7 +352,7 @@ public function configureOptions(OptionsResolver $resolver)
         $resolver->setAllowedTypes('choice_name', ['null', 'callable', 'string', PropertyPath::class, ChoiceFieldName::class]);
         $resolver->setAllowedTypes('choice_value', ['null', 'callable', 'string', PropertyPath::class, ChoiceValue::class]);
         $resolver->setAllowedTypes('choice_attr', ['null', 'array', 'callable', 'string', PropertyPath::class, ChoiceAttr::class]);
-        $resolver->setAllowedTypes('preferred_choices', ['array', '\Traversable', 'callable', 'string', PropertyPath::class, PreferredChoice::class]);
+        $resolver->setAllowedTypes('preferred_choices', ['array', \Traversable::class, 'callable', 'string', PropertyPath::class, PreferredChoice::class]);
         $resolver->setAllowedTypes('group_by', ['null', 'callable', 'string', PropertyPath::class, GroupBy::class]);
     }
 

Tests/ChoiceList/Factory/PropertyAccessDecoratorTest.php

@@ -78,7 +78,7 @@ public function testCreateFromChoicesFilterPropertyPath()
 
         $this->decoratedFactory->expects($this->once())
             ->method('createListFromChoices')
-            ->with($choices, $this->isInstanceOf('\Closure'), $this->isInstanceOf('\Closure'))
+            ->with($choices, $this->isInstanceOf(\Closure::class), $this->isInstanceOf(\Closure::class))
             ->willReturnCallback(function ($choices, $value, $callback) {
                 return new ArrayChoiceList(array_map($value, array_filter($choices, $callback)));
             });
@@ -97,7 +97,7 @@ public function testCreateFromChoicesFilterPropertyPathInstance()
 
         $this->decoratedFactory->expects($this->once())
             ->method('createListFromChoices')
-            ->with($choices, $this->isInstanceOf('\Closure'), $this->isInstanceOf('\Closure'))
+            ->with($choices, $this->isInstanceOf(\Closure::class), $this->isInstanceOf(\Closure::class))
             ->willReturnCallback(function ($choices, $value, $callback) {
                 return new ArrayChoiceList(array_map($value, array_filter($choices, $callback)));
             });
@@ -134,7 +134,7 @@ public function testCreateFromLoaderFilterPropertyPath()
 
         $this->decoratedFactory->expects($this->once())
             ->method('createListFromLoader')
-            ->with($loader, $this->isInstanceOf('\Closure'), $this->isInstanceOf('\Closure'))
+            ->with($loader, $this->isInstanceOf(\Closure::class), $this->isInstanceOf(\Closure::class))
             ->willReturnCallback(function ($loader, $value, $callback) use ($choices) {
                 return new ArrayChoiceList(array_map($value, array_filter($choices, $callback)));
             });

Tests/CompoundFormTest.php

@@ -22,6 +22,7 @@
 use Symfony\Component\Form\FormView;
 use Symfony\Component\Form\SubmitButtonBuilder;
 use Symfony\Component\Form\Tests\Fixtures\FixedDataTransformer;
+use Symfony\Component\Form\Util\InheritDataAwareIterator;
 use Symfony\Component\HttpFoundation\File\UploadedFile;
 use Symfony\Component\HttpFoundation\Request;
 
@@ -513,9 +514,9 @@ public function testSubmitMapsSubmittedChildrenOntoExistingViewData()
 
         $mapper->expects($this->once())
             ->method('mapFormsToData')
-            ->with($this->isInstanceOf('\RecursiveIteratorIterator'), 'bar')
+            ->with($this->isInstanceOf(\RecursiveIteratorIterator::class), 'bar')
             ->willReturnCallback(function (\RecursiveIteratorIterator $iterator) use ($child1, $child2) {
-                $this->assertInstanceOf('Symfony\Component\Form\Util\InheritDataAwareIterator', $iterator->getInnerIterator());
+                $this->assertInstanceOf(InheritDataAwareIterator::class, $iterator->getInnerIterator());
                 $this->assertSame(['firstName' => $child1, 'lastName' => $child2], iterator_to_array($iterator));
                 $this->assertEquals('Bernhard', $child1->getData());
                 $this->assertEquals('Schussek', $child2->getData());
@@ -585,9 +586,9 @@ public function testSubmitMapsSubmittedChildrenOntoEmptyData()
 
         $mapper->expects($this->once())
             ->method('mapFormsToData')
-            ->with($this->isInstanceOf('\RecursiveIteratorIterator'), $object)
+            ->with($this->isInstanceOf(\RecursiveIteratorIterator::class), $object)
             ->willReturnCallback(function (\RecursiveIteratorIterator $iterator) use ($child) {
-                $this->assertInstanceOf('Symfony\Component\Form\Util\InheritDataAwareIterator', $iterator->getInnerIterator());
+                $this->assertInstanceOf(InheritDataAwareIterator::class, $iterator->getInnerIterator());
                 $this->assertSame(['name' => $child], iterator_to_array($iterator));
             });
 

Tests/SimpleFormTest.php

@@ -882,7 +882,7 @@ public function testViewDataMayBeObjectIfDataClassIsNull()
 
     public function testViewDataMayBeArrayAccessIfDataClassIsNull()
     {
-        $arrayAccess = $this->getMockBuilder('\ArrayAccess')->getMock();
+        $arrayAccess = $this->getMockBuilder(\ArrayAccess::class)->getMock();
         $config = new FormConfigBuilder('name', null, $this->dispatcher);
         $config->addViewTransformer(new FixedDataTransformer([
             '' => '',