Skip to content

Commit 2997e0c

Browse files
committed
Merge branch '2.7' into 2.8
* 2.7: [SecurityBundle] only pass relevant user provider [Intl] Make tests pass after the ICU data update [Intl] Update ICU data to 58.2 [DependencyInjection] removed dead code. [Yaml] Stop replacing NULLs when merging
2 parents 81ba72f + b1d8212 commit 2997e0c

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ protected function setUp()
2424
parent::setUp();
2525

2626
// Since we test against "de_AT", we need the full implementation
27-
IntlTestHelper::requireFullIntl($this);
27+
IntlTestHelper::requireFullIntl($this, '57.1');
2828

2929
\Locale::setDefault('de_AT');
3030

Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ public function testReverseTransform($to, $from, $locale)
228228
public function testReverseTransformWithGrouping($to, $from, $locale)
229229
{
230230
// Since we test against other locales, we need the full implementation
231-
IntlTestHelper::requireFullIntl($this, false);
231+
IntlTestHelper::requireFullIntl($this, '4.8.1.1');
232232

233233
\Locale::setDefault($locale);
234234

@@ -375,7 +375,7 @@ public function testReverseTransformDoesNotRoundIfNoScale()
375375
public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsNotDot()
376376
{
377377
// Since we test against other locales, we need the full implementation
378-
IntlTestHelper::requireFullIntl($this, false);
378+
IntlTestHelper::requireFullIntl($this, '4.8.1.1');
379379

380380
\Locale::setDefault('fr');
381381
$transformer = new NumberToLocalizedStringTransformer(null, true);
@@ -395,7 +395,7 @@ public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsNotDot()
395395
public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot()
396396
{
397397
// Since we test against "de_DE", we need the full implementation
398-
IntlTestHelper::requireFullIntl($this, false);
398+
IntlTestHelper::requireFullIntl($this, '4.8.1.1');
399399

400400
\Locale::setDefault('de_DE');
401401

@@ -410,7 +410,7 @@ public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot()
410410
public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDotWithNoGroupSep()
411411
{
412412
// Since we test against "de_DE", we need the full implementation
413-
IntlTestHelper::requireFullIntl($this, false);
413+
IntlTestHelper::requireFullIntl($this, '4.8.1.1');
414414

415415
\Locale::setDefault('de_DE');
416416

@@ -434,7 +434,7 @@ public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsDotButNoGroupin
434434
public function testDecimalSeparatorMayBeCommaIfGroupingSeparatorIsNotComma()
435435
{
436436
// Since we test against other locales, we need the full implementation
437-
IntlTestHelper::requireFullIntl($this, false);
437+
IntlTestHelper::requireFullIntl($this, '4.8.1.1');
438438

439439
\Locale::setDefault('bg');
440440
$transformer = new NumberToLocalizedStringTransformer(null, true);
@@ -453,6 +453,8 @@ public function testDecimalSeparatorMayBeCommaIfGroupingSeparatorIsNotComma()
453453
*/
454454
public function testDecimalSeparatorMayNotBeCommaIfGroupingSeparatorIsComma()
455455
{
456+
IntlTestHelper::requireFullIntl($this, '4.8.1.1');
457+
456458
$transformer = new NumberToLocalizedStringTransformer(null, true);
457459

458460
$transformer->reverseTransform('1,234,5');
@@ -463,6 +465,8 @@ public function testDecimalSeparatorMayNotBeCommaIfGroupingSeparatorIsComma()
463465
*/
464466
public function testDecimalSeparatorMayNotBeCommaIfGroupingSeparatorIsCommaWithNoGroupSep()
465467
{
468+
IntlTestHelper::requireFullIntl($this, '4.8.1.1');
469+
466470
$transformer = new NumberToLocalizedStringTransformer(null, true);
467471

468472
$transformer->reverseTransform('1234,5');

Tests/Extension/Core/Type/DateTypeTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,7 @@ public function testMonthsOption()
514514
public function testMonthsOptionShortFormat()
515515
{
516516
// we test against "de_AT", so we need the full implementation
517-
IntlTestHelper::requireFullIntl($this);
517+
IntlTestHelper::requireFullIntl($this, '57.1');
518518

519519
\Locale::setDefault('de_AT');
520520

0 commit comments

Comments
 (0)