Skip to content

Commit 75682f2

Browse files
committed
[Form] DateTimeToRfc3339Transformer use proper transformation exteption in reverse transformation
1 parent 35abbb1 commit 75682f2

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

Extension/Core/DataTransformer/DateTimeToRfc3339Transformer.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,11 @@ public function reverseTransform($rfc3339)
5353
return null;
5454
}
5555

56-
$dateTime = new \DateTime($rfc3339);
56+
try {
57+
$dateTime = new \DateTime($rfc3339);
58+
} catch (\Exception $e) {
59+
throw new TransformationFailedException($e->getMessage(), $e->getCode(), $e);
60+
}
5761

5862
if ($this->outputTimezone !== $this->inputTimezone) {
5963
try {

Tests/Extension/Core/DataTransformer/DateTimeToRfc3339TransformerTest.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,4 +119,14 @@ public function testReverseTransformWithNonExistingDate()
119119

120120
$transformer->reverseTransform('2010-04-31T04:05Z');
121121
}
122+
123+
/**
124+
* @expectedException Symfony\Component\Form\Exception\TransformationFailedException
125+
*/
126+
public function testReverseTransformExpectsValidDateString()
127+
{
128+
$transformer = new DateTimeToRfc3339Transformer('UTC', 'UTC');
129+
130+
$transformer->reverseTransform('2010-2010-2010');
131+
}
122132
}

0 commit comments

Comments
 (0)