fixed issue with clone now the children of the original form are preserved and the clone form is given new children

Joseph Deray · Joseph Deray · commit a139b2a581a0 · 2013-10-30T18:44:30.000-04:00
diff --git a/Form.php b/Form.php
@@ -170,6 +170,8 @@ public function __construct(FormConfigInterface $config)
 
     public function __clone()
     {
+        $this->children = clone $this->children;
+        
         foreach ($this->children as $key => $child) {
             $this->children[$key] = clone $child;
         }
diff --git a/Tests/CompoundFormTest.php b/Tests/CompoundFormTest.php
@@ -141,6 +141,7 @@ public function testCloneChildren()
 
         $this->assertNotSame($this->form, $clone);
         $this->assertNotSame($child, $clone['child']);
+        $this->assertNotSame($this->form['child'], $clone['child']);
     }
 
     public function testNotEmptyIfChildNotEmpty()

Original file line number	Diff line number	Diff line change
`@@ -170,6 +170,8 @@ public function __construct(FormConfigInterface $config)`
`170`	`170`
`171`	`171`	`public function __clone()`
`172`	`172`	`{`
	`173`	`+ $this->children = clone $this->children;`
	`174`	`+`
`173`	`175`	`foreach ($this->children as $key => $child) {`
`174`	`176`	`$this->children[$key] = clone $child;`
`175`	`177`	`}`
Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,7 @@ public function testCloneChildren()`
`141`	`141`
`142`	`142`	`$this->assertNotSame($this->form, $clone);`
`143`	`143`	`$this->assertNotSame($child, $clone['child']);`
	`144`	`+ $this->assertNotSame($this->form['child'], $clone['child']);`
`144`	`145`	`}`
`145`	`146`
`146`	`147`	`public function testNotEmptyIfChildNotEmpty()`