Skip to content

Commit c886bae

Browse files
OskarStarkchalasr
authored andcommitted
Use createMock() instead of a getter
1 parent bab1af9 commit c886bae

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

Tests/FormFactoryTest.php

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public function testCreateNamedBuilderWithTypeName()
7777
{
7878
$options = ['a' => '1', 'b' => '2'];
7979
$resolvedOptions = ['a' => '2', 'b' => '3'];
80-
$resolvedType = $this->getMockResolvedType();
80+
$resolvedType = $this->createMock(ResolvedFormTypeInterface::class);
8181

8282
$this->registry->expects($this->once())
8383
->method('getType')
@@ -105,7 +105,7 @@ public function testCreateNamedBuilderFillsDataOption()
105105
$givenOptions = ['a' => '1', 'b' => '2'];
106106
$expectedOptions = array_merge($givenOptions, ['data' => 'DATA']);
107107
$resolvedOptions = ['a' => '2', 'b' => '3', 'data' => 'DATA'];
108-
$resolvedType = $this->getMockResolvedType();
108+
$resolvedType = $this->createMock(ResolvedFormTypeInterface::class);
109109

110110
$this->registry->expects($this->once())
111111
->method('getType')
@@ -132,7 +132,7 @@ public function testCreateNamedBuilderDoesNotOverrideExistingDataOption()
132132
{
133133
$options = ['a' => '1', 'b' => '2', 'data' => 'CUSTOM'];
134134
$resolvedOptions = ['a' => '2', 'b' => '3', 'data' => 'CUSTOM'];
135-
$resolvedType = $this->getMockResolvedType();
135+
$resolvedType = $this->createMock(ResolvedFormTypeInterface::class);
136136

137137
$this->registry->expects($this->once())
138138
->method('getType')
@@ -211,7 +211,7 @@ public function testCreateNamed()
211211
{
212212
$options = ['a' => '1', 'b' => '2'];
213213
$resolvedOptions = ['a' => '2', 'b' => '3'];
214-
$resolvedType = $this->getMockResolvedType();
214+
$resolvedType = $this->createMock(ResolvedFormTypeInterface::class);
215215

216216
$this->registry->expects($this->once())
217217
->method('getType')
@@ -485,9 +485,4 @@ private function getMockFactory(array $methods = [])
485485
->setConstructorArgs([$this->registry])
486486
->getMock();
487487
}
488-
489-
private function getMockResolvedType()
490-
{
491-
return $this->createMock(ResolvedFormTypeInterface::class);
492-
}
493488
}

0 commit comments

Comments
 (0)