Skip to content

Commit d9d8a21

Browse files
peterrehmnicolas-grekas
authored andcommitted
Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
1 parent 5e7dca8 commit d9d8a21

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

Tests/Extension/Core/DataTransformer/DateIntervalToArrayTransformerTest.php

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
namespace Symfony\Component\Form\Tests\Extension\Core\DataTransformer;
1313

1414
use Symfony\Component\Form\Extension\Core\DataTransformer\DateIntervalToArrayTransformer;
15+
use Symfony\Component\Form\Exception\TransformationFailedException;
16+
use Symfony\Component\Form\Exception\UnexpectedTypeException;
1517

1618
/**
1719
* @author Steffen Roßkamp <[email protected]>
@@ -159,15 +161,15 @@ public function testReverseTransformRequiresDateTime()
159161
{
160162
$transformer = new DateIntervalToArrayTransformer();
161163
$this->assertNull($transformer->reverseTransform(null));
162-
$this->setExpectedException('Symfony\Component\Form\Exception\UnexpectedTypeException');
164+
$this->{method_exists($this, $_ = 'expectException') ? $_ : 'setExpectedException'}(UnexpectedTypeException::class);
163165
$transformer->reverseTransform('12345');
164166
}
165167

166168
public function testReverseTransformWithUnsetFields()
167169
{
168170
$transformer = new DateIntervalToArrayTransformer();
169171
$input = array('years' => '1');
170-
$this->setExpectedException('Symfony\Component\Form\Exception\TransformationFailedException');
172+
$this->{method_exists($this, $_ = 'expectException') ? $_ : 'setExpectedException'}(TransformationFailedException::class);
171173
$transformer->reverseTransform($input);
172174
}
173175

@@ -179,7 +181,7 @@ public function testReverseTransformWithEmptyFields()
179181
'minutes' => '',
180182
'seconds' => '6',
181183
);
182-
$this->setExpectedException('Symfony\Component\Form\Exception\TransformationFailedException', 'This amount of "minutes" is invalid');
184+
$this->{method_exists($this, $_ = 'expectException') ? $_ : 'setExpectedException'}(TransformationFailedException::class, 'This amount of "minutes" is invalid');
183185
$transformer->reverseTransform($input);
184186
}
185187

@@ -189,7 +191,7 @@ public function testReverseTransformWithWrongInvertType()
189191
$input = array(
190192
'invert' => '1',
191193
);
192-
$this->setExpectedException('Symfony\Component\Form\Exception\TransformationFailedException', 'The value of "invert" must be boolean');
194+
$this->{method_exists($this, $_ = 'expectException') ? $_ : 'setExpectedException'}(TransformationFailedException::class, 'The value of "invert" must be boolean');
193195
$transformer->reverseTransform($input);
194196
}
195197

Tests/Extension/Core/DataTransformer/DateIntervalToStringTransformerTest.php

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
namespace Symfony\Component\Form\Tests\Extension\Core\DataTransformer;
1313

1414
use Symfony\Component\Form\Extension\Core\DataTransformer\DateIntervalToStringTransformer;
15+
use Symfony\Component\Form\Exception\TransformationFailedException;
16+
use Symfony\Component\Form\Exception\UnexpectedTypeException;
1517

1618
/**
1719
* @author Steffen Roßkamp <[email protected]>
@@ -73,7 +75,7 @@ public function testTransformEmpty()
7375
public function testTransformExpectsDateTime()
7476
{
7577
$transformer = new DateIntervalToStringTransformer();
76-
$this->setExpectedException('Symfony\Component\Form\Exception\UnexpectedTypeException');
78+
$this->{method_exists($this, $_ = 'expectException') ? $_ : 'setExpectedException'}(UnexpectedTypeException::class);
7779
$transformer->transform('1234');
7880
}
7981

@@ -94,7 +96,7 @@ public function testReverseTransformDateString($format, $input, $output)
9496
{
9597
$reverseTransformer = new DateIntervalToStringTransformer($format, true);
9698
$interval = new \DateInterval($output);
97-
$this->setExpectedException('Symfony\Component\Form\Exception\TransformationFailedException');
99+
$this->{method_exists($this, $_ = 'expectException') ? $_ : 'setExpectedException'}(TransformationFailedException::class);
98100
$this->assertDateIntervalEquals($interval, $reverseTransformer->reverseTransform($input));
99101
}
100102

@@ -107,14 +109,14 @@ public function testReverseTransformEmpty()
107109
public function testReverseTransformExpectsString()
108110
{
109111
$reverseTransformer = new DateIntervalToStringTransformer();
110-
$this->setExpectedException('Symfony\Component\Form\Exception\UnexpectedTypeException');
112+
$this->{method_exists($this, $_ = 'expectException') ? $_ : 'setExpectedException'}(UnexpectedTypeException::class);
111113
$reverseTransformer->reverseTransform(1234);
112114
}
113115

114116
public function testReverseTransformExpectsValidIntervalString()
115117
{
116118
$reverseTransformer = new DateIntervalToStringTransformer();
117-
$this->setExpectedException('Symfony\Component\Form\Exception\TransformationFailedException');
119+
$this->{method_exists($this, $_ = 'expectException') ? $_ : 'setExpectedException'}(TransformationFailedException::class);
118120
$reverseTransformer->reverseTransform('10Y');
119121
}
120122
}

0 commit comments

Comments
 (0)