Merge branch '4.2'

* 4.2:
  allow to skip tests based on the supported version
  Update validators.bg.xlf
  Update validators.ca.xlf
  fixed CS
  Updated validators.eu.xlf with missing translations
  fixed typo
  backported a translation
  [Validator] added missing translation for UK validator
  Validator: add the Persian translations
  Update validators.sq.xlf
  fixed CS
  forward valid numeric values to transform()
  add constraint validators before optimizations

Author: xabbuh

Extension/Core/DataTransformer/MoneyToLocalizedStringTransformer.php

@@ -58,7 +58,7 @@ public function transform($value)
             if (!is_numeric($value)) {
                 throw new TransformationFailedException('Expected a numeric.');
             }
-            $value = (string) ($value / $this->divisor);
+            $value /= $this->divisor;
         }
 
         return parent::transform($value);

Test/FormPerformanceTestCase.php

@@ -11,6 +11,8 @@
 
 namespace Symfony\Component\Form\Test;
 
+use Symfony\Component\Form\Tests\VersionAwareTest;
+
 /**
  * Base class for performance tests.
  *
@@ -21,6 +23,8 @@
  */
 abstract class FormPerformanceTestCase extends FormIntegrationTestCase
 {
+    use VersionAwareTest;
+
     /**
      * @var int
      */

Tests/AbstractLayoutTest.php

@@ -19,6 +19,8 @@
 
 abstract class AbstractLayoutTest extends FormIntegrationTestCase
 {
+    use VersionAwareTest;
+
     protected $csrfTokenManager;
     protected $testableFeatures = [];
 

Tests/Extension/Core/DataTransformer/MoneyToLocalizedStringTransformerTest.php

@@ -17,6 +17,18 @@
 
 class MoneyToLocalizedStringTransformerTest extends TestCase
 {
+    private $previousLocale;
+
+    protected function setUp()
+    {
+        $this->previousLocale = setlocale(LC_ALL, '0');
+    }
+
+    protected function tearDown()
+    {
+        setlocale(LC_ALL, $this->previousLocale);
+    }
+
     public function testTransform()
     {
         // Since we test against "de_AT", we need the full implementation
@@ -73,7 +85,7 @@ public function testReverseTransformEmpty()
         $this->assertNull($transformer->reverseTransform(''));
     }
 
-    public function testFloatToIntConversionMismatchOnReversTransform()
+    public function testFloatToIntConversionMismatchOnReverseTransform()
     {
         $transformer = new MoneyToLocalizedStringTransformer(null, null, null, 100);
         IntlTestHelper::requireFullIntl($this, false);
@@ -90,4 +102,16 @@ public function testFloatToIntConversionMismatchOnTransform()
 
         $this->assertSame('10,20', $transformer->transform(1020));
     }
+
+    public function testValidNumericValuesWithNonDotDecimalPointCharacter()
+    {
+        // calling setlocale() here is important as it changes the representation of floats when being cast to strings
+        setlocale(LC_ALL, 'de_AT.UTF-8');
+
+        $transformer = new MoneyToLocalizedStringTransformer(4, null, null, 100);
+        IntlTestHelper::requireFullIntl($this, false);
+        \Locale::setDefault('de_AT');
+
+        $this->assertSame('0,0035', $transformer->transform(12 / 34));
+    }
 }

Tests/Extension/Core/Type/BaseTypeTest.php

@@ -12,12 +12,15 @@
 namespace Symfony\Component\Form\Tests\Extension\Core\Type;
 
 use Symfony\Component\Form\Test\TypeTestCase;
+use Symfony\Component\Form\Tests\VersionAwareTest;
 
 /**
  * @author Bernhard Schussek <[email protected]>
  */
 abstract class BaseTypeTest extends TypeTestCase
 {
+    use VersionAwareTest;
+
     const TESTED_TYPE = '';
 
     public function testPassDisabledAsOption()

Tests/VersionAwareTest.php

@@ -0,0 +1,27 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Form\Tests;
+
+trait VersionAwareTest
+{
+    protected static $supportedFeatureSetVersion = 304;
+
+    /**
+     * @param int $requiredFeatureSetVersion
+     */
+    protected function requiresFeatureSet($requiredFeatureSetVersion)
+    {
+        if ($requiredFeatureSetVersion > static::$supportedFeatureSetVersion) {
+            $this->markTestSkipped(sprintf('Test requires features from symfony/form %.2f but only version %.2f is supported.', $requiredFeatureSetVersion / 100, static::$supportedFeatureSetVersion / 100));
+        }
+    }
+}