Skip to content

Commit 05f8e01

Browse files
minor #26002 Improve assertions (carusogabriel)
This PR was merged into the 3.4 branch. Discussion ---------- Improve assertions | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Following #25420 in `3.4` branch. Commits ------- 829f59d Improve assertions
2 parents 4fbc63a + 2b63528 commit 05f8e01

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Tests/DependencyInjection/FrameworkExtensionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1123,7 +1123,7 @@ private function assertCachePoolServiceDefinitionIsCreated(ContainerBuilder $con
11231123
$this->assertFalse($poolDefinition->isAbstract(), sprintf('Service definition "%s" is not abstract.', $id));
11241124

11251125
$tag = $poolDefinition->getTag('cache.pool');
1126-
$this->assertTrue(isset($tag[0]['default_lifetime']), 'The default lifetime is stored as an attribute of the "cache.pool" tag.');
1126+
$this->assertArrayHasKey('default_lifetime', $tag[0], 'The default lifetime is stored as an attribute of the "cache.pool" tag.');
11271127
$this->assertSame($defaultLifetime, $tag[0]['default_lifetime'], 'The default lifetime is stored as an attribute of the "cache.pool" tag.');
11281128

11291129
$parentDefinition = $poolDefinition;

0 commit comments

Comments
 (0)