feature #32807 [HttpClient] add "max_duration" option (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] add "max_duration" option

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony/symfony#32765
| License       | MIT
| Doc PR        | symfony/symfony-docs#12073

Commits
-------

a4178f1369 [HttpClient] add "max_duration" option

Author: nicolas-grekas

DependencyInjection/Configuration.php

@@ -1367,6 +1367,9 @@ private function addHttpClientSection(ArrayNodeDefinition $rootNode)
                                 ->floatNode('timeout')
                                     ->info('The idle timeout, defaults to the "default_socket_timeout" ini parameter.')
                                 ->end()
+                                ->floatNode('max_duration')
+                                    ->info('The maximum execution time for the request+response as a whole.')
+                                ->end()
                                 ->scalarNode('bindto')
                                     ->info('A network interface name, IP address, a host name or a UNIX socket to bind to.')
                                 ->end()
@@ -1503,6 +1506,9 @@ private function addHttpClientSection(ArrayNodeDefinition $rootNode)
                                     ->floatNode('timeout')
                                         ->info('The idle timeout, defaults to the "default_socket_timeout" ini parameter.')
                                     ->end()
+                                    ->floatNode('max_duration')
+                                        ->info('The maximum execution time for the request+response as a whole.')
+                                    ->end()
                                     ->scalarNode('bindto')
                                         ->info('A network interface name, IP address, a host name or a UNIX socket to bind to.')
                                     ->end()

Resources/config/schema/symfony-1.0.xsd

@@ -495,6 +495,7 @@
         <xsd:attribute name="proxy" type="xsd:string" />
         <xsd:attribute name="no-proxy" type="xsd:string" />
         <xsd:attribute name="timeout" type="xsd:float" />
+        <xsd:attribute name="max-duration" type="xsd:float" />
         <xsd:attribute name="bindto" type="xsd:string" />
         <xsd:attribute name="verify-peer" type="xsd:boolean" />
         <xsd:attribute name="verify-host" type="xsd:boolean" />

Tests/DependencyInjection/Fixtures/php/http_client_full_default_options.php

@@ -9,6 +9,7 @@
             'resolve' => ['localhost' => '127.0.0.1'],
             'proxy' => 'proxy.org',
             'timeout' => 3.5,
+            'max_duration' => 10.1,
             'bindto' => '127.0.0.1',
             'verify_peer' => true,
             'verify_host' => true,

Tests/DependencyInjection/Fixtures/xml/http_client_full_default_options.xml

@@ -11,6 +11,7 @@
                     proxy="proxy.org"
                     bindto="127.0.0.1"
                     timeout="3.5"
+                    max-duration="10.1"
                     verify-peer="true"
                     max-redirects="2"
                     http-version="2.0"

Tests/DependencyInjection/Fixtures/yml/http_client_full_default_options.yml

@@ -8,6 +8,7 @@ framework:
             resolve: {'localhost': '127.0.0.1'}
             proxy: proxy.org
             timeout: 3.5
+            max_duration: 10.1
             bindto: 127.0.0.1
             verify_peer: true
             verify_host: true

Tests/DependencyInjection/FrameworkExtensionTest.php

@@ -1547,6 +1547,7 @@ public function testHttpClientFullDefaultOptions()
         $this->assertSame(['localhost' => '127.0.0.1'], $defaultOptions['resolve']);
         $this->assertSame('proxy.org', $defaultOptions['proxy']);
         $this->assertSame(3.5, $defaultOptions['timeout']);
+        $this->assertSame(10.1, $defaultOptions['max_duration']);
         $this->assertSame('127.0.0.1', $defaultOptions['bindto']);
         $this->assertTrue($defaultOptions['verify_peer']);
         $this->assertTrue($defaultOptions['verify_host']);