Skip to content

Commit 0cc8fd0

Browse files
Merge branch '3.2'
* 3.2: [Yaml] CS [DI] Fix PhpDumper generated doc block #20411 fix Yaml parsing for very long quoted strings [Workflow] add Phpdoc for better IDE support fix package name in conflict rule improve message when workflows are missing [Doctrine Bridge] fix priority for doctrine event listeners Use PHP functions as array_map callbacks when possible [Validator] revert wrong Phpdoc change Use proper line endings
2 parents bdf5b81 + 6a626d5 commit 0cc8fd0

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

DependencyInjection/FrameworkExtension.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -423,6 +423,10 @@ private function registerWorkflowConfiguration(array $workflows, ContainerBuilde
423423
return;
424424
}
425425

426+
if (!class_exists(Workflow\Workflow::class)) {
427+
throw new LogicException('Workflow support cannot be enabled as the Workflow component is not installed.');
428+
}
429+
426430
$loader->load('workflow.xml');
427431

428432
$registryDefinition = $container->getDefinition('workflow.registry');

Tests/DependencyInjection/FrameworkExtensionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,7 @@ public function testTranslator()
419419
$this->assertEquals('translator.default', (string) $container->getAlias('translator'), '->registerTranslatorConfiguration() redefines translator service from identity to real translator');
420420
$options = $container->getDefinition('translator.default')->getArgument(3);
421421

422-
$files = array_map(function ($resource) { return realpath($resource); }, $options['resource_files']['en']);
422+
$files = array_map('realpath', $options['resource_files']['en']);
423423
$ref = new \ReflectionClass('Symfony\Component\Validator\Validation');
424424
$this->assertContains(
425425
strtr(dirname($ref->getFileName()).'/Resources/translations/validators.en.xlf', '/', DIRECTORY_SEPARATOR),

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
"symfony/translation": "~3.2",
5151
"symfony/templating": "~2.8|~3.0",
5252
"symfony/validator": "~3.3",
53+
"symfony/workflow": "~3.3",
5354
"symfony/yaml": "~3.2",
5455
"symfony/property-info": "~3.3",
5556
"doctrine/annotations": "~1.0",
@@ -66,7 +67,7 @@
6667
"symfony/form": "<3.3",
6768
"symfony/property-info": "<3.3",
6869
"symfony/serializer": "<3.3",
69-
"symfony/translations": "<3.2",
70+
"symfony/translation": "<3.2",
7071
"symfony/validator": "<3.3",
7172
"symfony/workflow": "<3.3"
7273
},

0 commit comments

Comments
 (0)