Merge branch '2.3'

fabpot · fabpot · commit 24591185ff60 · 2013-08-15T19:09:02.000+02:00
* 2.3:
  Added sleep() workaround for windows php rename bug
  [HttpKernel] removed unused variable
  [Form] Fixed: Added "validation_groups" option to submit button
  [Process] Fix for #8754 (Timed-out processes are successful)

Conflicts:
	src/Symfony/Component/Form/Tests/Extension/Validator/Type/FormTypeValidatorExtensionTest.php
diff --git a/Command/CacheClearCommand.php b/Command/CacheClearCommand.php
@@ -83,6 +83,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $this->warmup($warmupDir, $realCacheDir, !$input->getOption('no-optional-warmers'));
 
             $filesystem->rename($realCacheDir, $oldCacheDir);
+            if (defined('PHP_WINDOWS_VERSION_BUILD')) {
+                sleep(1);  // workaround for windows php rename bug
+            }
             $filesystem->rename($warmupDir, $realCacheDir);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -83,6 +83,9 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`83`	`83`	`$this->warmup($warmupDir, $realCacheDir, !$input->getOption('no-optional-warmers'));`
`84`	`84`
`85`	`85`	`$filesystem->rename($realCacheDir, $oldCacheDir);`
	`86`	`+ if (defined('PHP_WINDOWS_VERSION_BUILD')) {`
	`87`	`+ sleep(1); // workaround for windows php rename bug`
	`88`	`+ }`
`86`	`89`	`$filesystem->rename($warmupDir, $realCacheDir);`
`87`	`90`	`}`
`88`	`91`