minor #57775 [HttpFoundation][HttpKernel] Remove unused code and useless casts (alexandre-daubois)

This PR was merged into the 7.2 branch.

Discussion
----------

[HttpFoundation][HttpKernel] Remove unused code and useless casts

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Removed some superfluous code and useless casts across HttpFoundation and HttpKernel

Commits
-------

c26bb3af75 [HttpFoundation][HttpKernel] Remove dead code and useless casts

Author: fabpot

CacheWarmer/RouterCacheWarmer.php

@@ -43,7 +43,7 @@ public function warmUp(string $cacheDir, ?string $buildDir = null): array
         $router = $this->container->get('router');
 
         if ($router instanceof WarmableInterface) {
-            return (array) $router->warmUp($cacheDir, $buildDir);
+            return $router->warmUp($cacheDir, $buildDir);
         }
 
         throw new \LogicException(\sprintf('The router "%s" cannot be warmed up because it does not implement "%s".', get_debug_type($router), WarmableInterface::class));

CacheWarmer/TranslationsCacheWarmer.php

@@ -40,7 +40,7 @@ public function warmUp(string $cacheDir, ?string $buildDir = null): array
         $this->translator ??= $this->container->get('translator');
 
         if ($this->translator instanceof WarmableInterface) {
-            return (array) $this->translator->warmUp($cacheDir, $buildDir);
+            return $this->translator->warmUp($cacheDir, $buildDir);
         }
 
         return [];

Tests/CacheWarmer/RouterCacheWarmerTest.php

@@ -24,6 +24,8 @@ public function testWarmUpWithWarmableInterfaceWithBuildDir()
         $container = new Container();
 
         $routerMock = $this->getMockBuilder(testRouterInterfaceWithWarmableInterface::class)->onlyMethods(['match', 'generate', 'getContext', 'setContext', 'getRouteCollection', 'warmUp'])->getMock();
+        $routerMock->method('warmUp')->willReturn([]);
+
         $container->set('router', $routerMock);
         $routerCacheWarmer = new RouterCacheWarmer($container);